Skip to content

[pwm] Add second-level command completion #8398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mysterywolf merged 1 commit into from
Dec 25, 2023
Merged

[pwm] Add second-level command completion #8398

mysterywolf merged 1 commit into from
Dec 25, 2023

Conversation

@1ridic
Copy link
Contributor

@1ridic 1ridic commented Dec 23, 2023 •
edited
Loading

拉取/合并请求描述：(PR description)

给 finsh 的 pwm 命令添加二级命令补全。

更改后的效果，可以用 tab 触发补全：

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@mysterywolf
Copy link
Member

mysterywolf commented Dec 23, 2023

能在描述里增加一下描述内容吗 主要是解决了什么问题 改前是什么样子的 改后是什么样子的

@1ridic
Copy link
Contributor Author

1ridic commented Dec 23, 2023

添加说明了

@mysterywolf mysterywolf added the +1 Agree +1 label Dec 23, 2023
@mysterywolf mysterywolf merged commit 3da0b76 into RT-Thread:master Dec 25, 2023
mysterywolf added a commit that referenced this pull request Mar 29, 2024
@mysterywolf
[msh] add comment for secondary-commands
300f82d 
新增加的二级命令使用方式没有清晰的描述
功能实现PR：#8086
补充优化PR：#8251
使用二级命令的例子：#8398
相关issue：#8691
@mysterywolf mysterywolf mentioned this pull request Mar 29, 2024
Merged
9 tasks
mysterywolf added a commit that referenced this pull request Mar 29, 2024
@mysterywolf
[msh] add comment for secondary-commands
db54521 
新增加的二级命令使用方式没有清晰的描述
- 功能实现PR：#8086
- 补充优化PR：#8251
- 使用二级命令的例子：#8398
- 相关issue：#8691
mysterywolf added a commit that referenced this pull request Mar 30, 2024
@mysterywolf
[msh] add comment for secondary-commands
6d1bc9b 
新增加的二级命令使用方式没有清晰的描述
- 功能实现PR：#8086
- 补充优化PR：#8251
- 使用二级命令的例子：#8398
- 相关issue：#8691
mysterywolf added a commit that referenced this pull request Apr 17, 2024
@mysterywolf
[msh] add comment for secondary-commands
e3d5703 
新增加的二级命令使用方式没有清晰的描述
- 功能实现PR：#8086
- 补充优化PR：#8251
- 使用二级命令的例子：#8398
- 相关issue：#8691
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mysterywolf mysterywolf mysterywolf approved these changes

@Guozhanxin Guozhanxin Awaiting requested review from Guozhanxin

@supperthomas supperthomas Awaiting requested review from supperthomas

@Rbb666 Rbb666 Awaiting requested review from Rbb666

Assignees

No one assigned

Labels

+1 Agree +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@1ridic @mysterywolf