Skip to content

FINSH: 优化MSH宏定义 #8251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BernardXiong merged 1 commit into from
Nov 15, 2023
Merged

FINSH: 优化MSH宏定义 #8251

BernardXiong merged 1 commit into from
Nov 15, 2023

Conversation

@HelloByeAll
Copy link
Contributor

@HelloByeAll HelloByeAll commented Nov 12, 2023

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

在什么测试环境下测试通过 (what is the test environment)

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@Guozhanxin Guozhanxin added the +1 Agree +1 label Nov 15, 2023
mysterywolf
mysterywolf reviewed Nov 15, 2023
View reviewed changes
components/finsh/finsh.h
Comment on lines +197 to +198
#define MSH_OPT_ID_GET(fun) ((int)(-1UL))
#define MSH_OPT_DUMP(fun) do{}while(0)
Copy link
Member

@mysterywolf mysterywolf Nov 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这两个宏好像没有被使用到

Copy link
Contributor Author

@HelloByeAll HelloByeAll Nov 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

抛给命令使用的 cmd.c中有示例

@BernardXiong BernardXiong merged commit b80a455 into RT-Thread:master Nov 15, 2023
ramangopalan pushed a commit to ramangopalan/rt-thread that referenced this pull request Nov 16, 2023
@HelloByeAll @ramangopalan
FINSH: 优化MSH宏定义 (RT-Thread#8251)
77cdd97
mysterywolf added a commit to mysterywolf/rt-thread that referenced this pull request Nov 26, 2023
@mysterywolf
Revert "FINSH: 优化MSH宏定义 (RT-Thread#8251)"
02499fe 
This reverts commit b80a455.
mysterywolf added a commit that referenced this pull request Mar 29, 2024
@mysterywolf
[msh] add comment for secondary-commands
300f82d 
新增加的二级命令使用方式没有清晰的描述
功能实现PR：#8086
补充优化PR：#8251
使用二级命令的例子：#8398
相关issue：#8691
@mysterywolf mysterywolf mentioned this pull request Mar 29, 2024
Merged
9 tasks
mysterywolf added a commit that referenced this pull request Mar 29, 2024
@mysterywolf
[msh] add comment for secondary-commands
db54521 
新增加的二级命令使用方式没有清晰的描述
- 功能实现PR：#8086
- 补充优化PR：#8251
- 使用二级命令的例子：#8398
- 相关issue：#8691
mysterywolf added a commit that referenced this pull request Mar 30, 2024
@mysterywolf
[msh] add comment for secondary-commands
6d1bc9b 
新增加的二级命令使用方式没有清晰的描述
- 功能实现PR：#8086
- 补充优化PR：#8251
- 使用二级命令的例子：#8398
- 相关issue：#8691
mysterywolf added a commit that referenced this pull request Apr 17, 2024
@mysterywolf
[msh] add comment for secondary-commands
e3d5703 
新增加的二级命令使用方式没有清晰的描述
- 功能实现PR：#8086
- 补充优化PR：#8251
- 使用二级命令的例子：#8398
- 相关issue：#8691
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mysterywolf mysterywolf mysterywolf left review comments

@Guozhanxin Guozhanxin Guozhanxin approved these changes

Assignees

No one assigned

Labels

+1 Agree +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HelloByeAll @Guozhanxin @mysterywolf @BernardXiong