Skip to content

Conversation

@dejavudwh
Copy link
Contributor

@dejavudwh dejavudwh commented May 14, 2023

拉取/合并请求描述:(PR description)

添加了根据ignore_format.yml的ignore_files属性过滤掉不需要cppcheck的文件。

为什么提交这份PR (why to submit this PR)

#7458

你的解决方案是什么 (what is your solution)

  1. 遍历整个目录获得所有.ignore_format.yml文件
    1.1 读取yml文件
    1.2 如果是目录则添加整个目录的文件,否则添加yml的描述文件
    1.3 输出一个要过滤的文件列表
  2. git diff 列出修改文件
    2.1 对比要过滤的文件列表
    2.2 筛选之后再进行cppcheck

在什么测试环境下测试通过 (what is the test environment)

fork后repo中的github action测试通过。

修改cppcheck会出现错误的文件:

  • case 1:不将文件加入.ignore_format.yml,CI报错
  • case 2:将文件加入.ignore_format.yml的file_path,CI不报错
  • case 3:将文件加入.ignore_format.yml的dir_path,CI不报错

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@dejavudwh
Copy link
Contributor Author

          建议重新开一个PR,将脚本放到tools/ci/文件夹下

Originally posted by @mysterywolf in #7469 (comment)

已经完成。

@dejavudwh
Copy link
Contributor Author

@supperthomas @mysterywolf
晚一点我把这个功能加入file_check.py中再提一个PR,可以对比一下怎么样更好一点。

@supperthomas supperthomas added the action github action yml imporve label May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action github action yml imporve

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants