Skip to content

Conversation

@flyingcys
Copy link
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

在什么测试环境下测试通过 (what is the test environment)

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@mysterywolf mysterywolf requested a review from Guozhanxin May 12, 2023 01:24
@mysterywolf mysterywolf added the +1 Agree +1 label May 12, 2023
@Guozhanxin
Copy link
Member

Guozhanxin commented May 12, 2023

有没有测试过dist之后能不能编过,我之前在stm32上也改过,然后发现dist之后就编不过了

@mysterywolf
Copy link
Member

dist可以先不用测,dist这块逻辑之前开会的时候说过 有问题,刘源会重新梳理一下。

@BernardXiong BernardXiong merged commit acb5010 into RT-Thread:master May 12, 2023
@flyingcys flyingcys deleted the update-libraries-path branch June 8, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

+1 Agree +1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants