Skip to content

fix lwp _load_script. #7405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Guozhanxin merged 2 commits into from
Apr 28, 2023
Merged

fix lwp _load_script. #7405

Guozhanxin merged 2 commits into from
Apr 28, 2023

Conversation

@geniusgogo
Copy link
Contributor

@geniusgogo geniusgogo commented Apr 27, 2023

拉取/合并请求描述：(PR description)

[

  • 修复sys_execve系统调用在解析脚本参数的时候错误的释放了空指针
  • 修复参数解析过程未能正确释放旧内存缓冲区的问题
    ]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

supperthomas
supperthomas requested changes Apr 27, 2023
View reviewed changes
Copy link
Member

@supperthomas supperthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请帮忙看下CI的warning是否需要处理。
components/lwp/lwp_syscall.c:2020:5: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg]
old_page = new_page;

@Guozhanxin
Copy link
Member

Guozhanxin commented Apr 28, 2023

请帮忙看下CI的warning是否需要处理。

components/lwp/lwp_syscall.c:2020:5: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg]

old_page = new_page;

看起来 old_page是个局部参数，这里赋值之后后面就没用过，所以这一行代码没啥意义……

@Guozhanxin Guozhanxin added the +1 Agree +1 label Apr 28, 2023
@Guozhanxin Guozhanxin merged commit 18c452e into RT-Thread:master Apr 28, 2023
@geniusgogo geniusgogo deleted the fix_lwp_load_script branch August 23, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Guozhanxin Guozhanxin Guozhanxin approved these changes

@supperthomas supperthomas supperthomas approved these changes

@BernardXiong BernardXiong Awaiting requested review from BernardXiong BernardXiong is a code owner

Assignees

No one assigned

Labels

+1 Agree +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@geniusgogo @Guozhanxin @supperthomas