[bsp/nxp/mcx/mcxa] Fix UART clock configuration type mismatch #10797

illustriousness · 2025-10-12T13:39:32Z

拉取/合并请求描述：(PR description)

[

Summary

Fixed implicit type conversion warning in NXP MCXA series UART driver by correctly
using the appropriate clock enum types.

Problem

The compiler reported a warning:
implicit conversion from 'int' to 'clock_name_t' changes value from 16777216 to 0

This occurred because the code was using clock_attach_id_t enum values (like
kFRO12M_to_LPUART0) in a field that expects clock_name_t enum type.

Root Cause

The mcx_uart structure has two separate clock-related fields with different
purposes:
- clock_src (type: clock_name_t): Used for getting clock frequency via
  CLOCK_GetFreq()
- clock_attach_id (type: clock_attach_id_t): Used for attaching clock source via
  CLOCK_AttachClk()
The original code incorrectly used kFRO12M_to_LPUARTx (a clock_attach_id_t value)
for the clock_src field.

Changes Made

Fixed clock source field: Now correctly uses kCLOCK_Fro12M (clock_name_t) for
all three UARTs
Kept clock attach field: Preserved kFRO12M_to_LPUARTx (clock_attach_id_t) for
clock routing
Fixed mcx_getc() function: Changed from kLPUART_RxDataRegFullInterruptEnable
to kLPUART_RxDataRegFullFlag for correct status checking

Testing

Tested on FRDM-MCXA156 board
UART transmission and reception working correctly
Compiler warning resolved

Impact

Fixes compilation warning
Ensures correct baud rate calculation by providing the right clock frequency

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

已经仔细查看过代码改动的对比 Already check the difference between PR and old code
代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
代码是高质量的 Code in this PR is of high quality
已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

github-actions · 2025-10-12T13:39:40Z

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

前往 Actions 页面 | Go to the Actions page
点击进入工作流 → | Click to open workflow →
点击 Run workflow | Click Run workflow

设置需排除的文件/目录（目录请以"/"结尾）
Set files/directories to exclude (directories should end with "/")
将目标分支设置为 \ Set the target branch to：fix_nxp_uart
设置PR number为 \ Set the PR number to：10797

等待工作流完成 | Wait for the workflow to complete
格式化后的代码将自动推送至你的分支。
The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 fix_nxp_uart 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the fix_nxp_uart branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

github-actions · 2025-10-12T13:39:43Z

📌 Code Review Assignment

🏷️ Tag: bsp_mcxa

Reviewers: hywing

Changed Files (Click to expand)

bsp/nxp/mcx/mcxa/Libraries/drivers/drv_uart.c

📊 Current Review Status (Last Updated: 2025-10-13 09:44 CST)

⌛ hywing Pending Review

📝 Review Instructions

维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
Maintainers can refresh the review status by clicking here: 🔄 Refresh Status
确认审核通过后评论 LGTM/lgtm
Comment LGTM/lgtm after confirming approval
PR合并前需至少一位维护者确认
PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

illustriousness · 2025-10-12T15:12:30Z

  /home/runner/work/rt-thread/rt-thread/components/lwp/lwp.h:88:2: error: #error "No compatible lwp set status provided for this libc"
     88 | #error "No compatible lwp set status provided for this libc"
        |  ^~~~~
  In file included from drivers/imx6ull.h:18,
                   from drivers/board.h:14,
                   from drivers/bsp_clock.c:12:
  /home/runner/work/rt-thread/rt-thread/components/lwp/lwp.h:88:2: error: #error "No compatible lwp set status provided for this libc"
     88 | #error "No compatible lwp set status provided for this libc"
        |  ^~~~~
  In file included from drivers/imx6ull.h:18,
                   from drivers/board.h:14,
                   from drivers/drv_common.c:14:
  /home/runner/work/rt-thread/rt-thread/components/lwp/lwp.h:88:2: error: #error "No compatible lwp set status provided for this libc"
     88 | #error "No compatible lwp set status provided for this libc"
        |  ^~~~~
  In file included from drivers/imx6ull.h:18,
                   from drivers/board.h:14,
                   from drivers/drv_common.h:15,
                   from drivers/drv_adc.c:24:
  /home/runner/work/rt-thread/rt-thread/components/lwp/lwp.h:88:2: error: #error "No compatible lwp set status provided for this libc"
     88 | #error "No compatible lwp set status provided for this libc"
        |  ^~~~~

报错好像和libc有关大佬帮忙看看

Fixed implicit type conversion warning in UART driver by correctly separating clock_name_t and clock_attach_id_t enum types. Changes: - Use kCLOCK_Fro12M (clock_name_t) for clock_src field - Keep kFRO12M_to_LPUARTx (clock_attach_id_t) for clock_attach_id field - Fix mcx_getc() to use correct status flag kLPUART_RxDataRegFullFlag This resolves the compiler warning: "implicit conversion from 'int' to 'clock_name_t' changes value from 16777216 to 0" Signed-off-by: Yucai Liu [email protected]

Rbb666 · 2025-10-13T02:49:53Z

@imi415 大佬帮忙看看

imi415

LGTM. By the way, is this clock_name_t really necessary?

illustriousness · 2025-10-14T10:09:07Z

LGTM. By the way, is this clock_name_t really necessary?

It seems that this can be removed. Currently, all three serial ports are using the same clock_name_t parameter.

illustriousness · 2025-10-20T09:04:41Z

  /home/runner/work/rt-thread/rt-thread/components/lwp/lwp.h:88:2: error: #error "No compatible lwp set status provided for this libc"
     88 | #error "No compatible lwp set status provided for this libc"
        |  ^~~~~
  In file included from drivers/imx6ull.h:18,
                   from drivers/board.h:14,
                   from drivers/bsp_clock.c:12:
  /home/runner/work/rt-thread/rt-thread/components/lwp/lwp.h:88:2: error: #error "No compatible lwp set status provided for this libc"
     88 | #error "No compatible lwp set status provided for this libc"
        |  ^~~~~
  In file included from drivers/imx6ull.h:18,
                   from drivers/board.h:14,
                   from drivers/drv_common.c:14:
  /home/runner/work/rt-thread/rt-thread/components/lwp/lwp.h:88:2: error: #error "No compatible lwp set status provided for this libc"
     88 | #error "No compatible lwp set status provided for this libc"
        |  ^~~~~
  In file included from drivers/imx6ull.h:18,
                   from drivers/board.h:14,
                   from drivers/drv_common.h:15,
                   from drivers/drv_adc.c:24:
  /home/runner/work/rt-thread/rt-thread/components/lwp/lwp.h:88:2: error: #error "No compatible lwp set status provided for this libc"
     88 | #error "No compatible lwp set status provided for this libc"
        |  ^~~~~

报错好像和libc有关大佬帮忙看看

@Rbb666

Rbb666 · 2025-10-21T02:27:41Z

  /home/runner/work/rt-thread/rt-thread/components/lwp/lwp.h:88:2: error: #error "No compatible lwp set status provided for this libc"
     88 | #error "No compatible lwp set status provided for this libc"
        |  ^~~~~
  In file included from drivers/imx6ull.h:18,
                   from drivers/board.h:14,
                   from drivers/bsp_clock.c:12:
  /home/runner/work/rt-thread/rt-thread/components/lwp/lwp.h:88:2: error: #error "No compatible lwp set status provided for this libc"
     88 | #error "No compatible lwp set status provided for this libc"
        |  ^~~~~
  In file included from drivers/imx6ull.h:18,
                   from drivers/board.h:14,
                   from drivers/drv_common.c:14:
  /home/runner/work/rt-thread/rt-thread/components/lwp/lwp.h:88:2: error: #error "No compatible lwp set status provided for this libc"
     88 | #error "No compatible lwp set status provided for this libc"
        |  ^~~~~
  In file included from drivers/imx6ull.h:18,
                   from drivers/board.h:14,
                   from drivers/drv_common.h:15,
                   from drivers/drv_adc.c:24:
  /home/runner/work/rt-thread/rt-thread/components/lwp/lwp.h:88:2: error: #error "No compatible lwp set status provided for this libc"
     88 | #error "No compatible lwp set status provided for this libc"
        |  ^~~~~

报错好像和libc有关大佬帮忙看看

@Rbb666

这个忽略即可，属于误报

illustriousness requested a review from Rbb666 as a code owner October 12, 2025 13:39

github-actions bot added BSP: NXP Code related with NXP BSP labels Oct 12, 2025

illustriousness force-pushed the fix_nxp_uart branch from ad1dbd9 to 1899457 Compare October 13, 2025 01:44

Rbb666 approved these changes Oct 13, 2025

View reviewed changes

imi415 approved these changes Oct 14, 2025

View reviewed changes

Rbb666 approved these changes Oct 21, 2025

View reviewed changes

Rbb666 added this to the v5.2.2 milestone Oct 21, 2025

Rbb666 merged commit 982e52e into RT-Thread:master Oct 21, 2025
28 of 29 checks passed

Rbb666 linked an issue Oct 21, 2025 that may be closed by this pull request

[Feature] 5.2.2 版本需合并PR汇总 #10835

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[bsp/nxp/mcx/mcxa] Fix UART clock configuration type mismatch #10797

[bsp/nxp/mcx/mcxa] Fix UART clock configuration type mismatch #10797

Uh oh!

illustriousness commented Oct 12, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 12, 2025

Uh oh!

github-actions bot commented Oct 12, 2025 •

edited

Loading

Uh oh!

illustriousness commented Oct 12, 2025 •

edited

Loading

Uh oh!

Rbb666 commented Oct 13, 2025

Uh oh!

imi415 left a comment

Uh oh!

illustriousness commented Oct 14, 2025

Uh oh!

illustriousness commented Oct 20, 2025

Uh oh!

Rbb666 commented Oct 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[bsp/nxp/mcx/mcxa] Fix UART clock configuration type mismatch #10797

[bsp/nxp/mcx/mcxa] Fix UART clock configuration type mismatch #10797

Uh oh!

Conversation

illustriousness commented Oct 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

拉取/合并请求描述：(PR description)

Summary

Problem

Root Cause

Changes Made

Testing

Impact

当前拉取/合并请求的状态 Intent for your PR

代码质量 Code Quality：

Uh oh!

github-actions bot commented Oct 12, 2025

🛠 操作步骤 | Steps

Uh oh!

github-actions bot commented Oct 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📌 Code Review Assignment

🏷️ Tag: bsp_mcxa

📊 Current Review Status (Last Updated: 2025-10-13 09:44 CST)

📝 Review Instructions

Uh oh!

illustriousness commented Oct 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Rbb666 commented Oct 13, 2025

Uh oh!

imi415 left a comment

Choose a reason for hiding this comment

Uh oh!

illustriousness commented Oct 14, 2025

Uh oh!

illustriousness commented Oct 20, 2025

Uh oh!

Rbb666 commented Oct 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

illustriousness commented Oct 12, 2025 •

edited

Loading

github-actions bot commented Oct 12, 2025 •

edited

Loading

illustriousness commented Oct 12, 2025 •

edited

Loading