Skip to content

feat[SPI]: Add SPI device detach function #10733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Rbb666 merged 1 commit into from
Sep 25, 2025
Merged

feat[SPI]: Add SPI device detach function #10733

Rbb666 merged 1 commit into from
Sep 25, 2025

Conversation

@wdfk-prog
Copy link
Contributor

@wdfk-prog wdfk-prog commented Sep 24, 2025 •
edited
Loading

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions
Copy link

github-actions bot commented Sep 24, 2025 •
edited
Loading

📌 Code Review Assignment

🏷️ Tag: bsp_stm32

Reviewers: Liang1795 hamburger-os wdfk-prog

Changed Files (Click to expand)
  • bsp/stm32/libraries/HAL_Drivers/drivers/drv_spi.c
  • bsp/stm32/libraries/HAL_Drivers/drivers/drv_spi.h

🏷️ Tag: components

Reviewers: Maihuanyi

Changed Files (Click to expand)
  • components/drivers/include/drivers/dev_spi.h
  • components/drivers/spi/dev_spi_core.c

🏷️ Tag: components_driver_spi

Reviewers: Liang1795 wdfk-prog

Changed Files (Click to expand)
  • components/drivers/spi/dev_spi_core.c

📊 Current Review Status (Last Updated: 2025-09-25 10:32 CST)

  • ⌛ Liang1795 Pending Review
  • ⌛ Maihuanyi Pending Review
  • ⌛ hamburger-os Pending Review
  • ⌛ wdfk-prog Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@github-actions
Copy link

github-actions bot commented Sep 24, 2025

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below.

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录（目录请以"/"结尾）
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to：spi_deinit
  • 设置PR number为 \ Set the PR number to：10733
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 spi_deinit 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the spi_deinit branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@wdfk-prog wdfk-prog mentioned this pull request Sep 24, 2025
Closed
@Rbb666 Rbb666 requested a review from Copilot September 24, 2025 10:10
Copilot AI reviewed Sep 24, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds detach functionality for SPI devices in RT-Thread, enabling proper cleanup and removal of SPI devices from the system. This is a complementary feature to the existing attach functionality.

  • Adds core detach functions for SPI devices in the driver framework
  • Implements hardware-specific detach function for STM32 BSP
  • Provides proper resource cleanup including device unregistration and CS pin reset

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
components/drivers/spi/dev_spi_core.c Implements core SPI device detach functions with resource cleanup
components/drivers/include/drivers/dev_spi.h Adds function declarations and documentation for detach APIs
bsp/stm32/libraries/HAL_Drivers/drivers/drv_spi.h Declares STM32-specific SPI device detach function
bsp/stm32/libraries/HAL_Drivers/drivers/drv_spi.c Implements STM32-specific SPI device detach with memory cleanup

bsp/stm32/libraries/HAL_Drivers/drivers/drv_spi.c
return result;
}

rt_free(spi_device);
Copy link

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

English: The function frees the SPI device memory directly, but this assumes the device was dynamically allocated. If the device was statically allocated or managed elsewhere, this will cause undefined behavior or memory corruption.

中文: 该函数直接释放SPI设备内存，但这假设设备是动态分配的。如果设备是静态分配的或在其他地方管理，这将导致未定义行为或内存损坏。

Suggested change
rt_free(spi_device);
/* Do not free spi_device here, as its allocation source is unknown. */

Copilot uses AI. Check for mistakes.
@Rbb666 Rbb666 added this to the v5.2.2 milestone Sep 24, 2025
@Rbb666 Rbb666 merged commit 7e5cd48 into RT-Thread:master Sep 25, 2025
67 checks passed
@wdfk-prog wdfk-prog deleted the spi_deinit branch September 25, 2025 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Rbb666 Rbb666 Rbb666 approved these changes

Assignees

No one assigned

Labels

BSP: STM32 BSP related with ST/STM32 BSP component: drivers/spi component: drivers Component

Projects

None yet

Milestone

v5.2.2

Development

Successfully merging this pull request may close these issues.

2 participants

@wdfk-prog @Rbb666