Skip to content

ci: fixed the abnormal operation of ci files #10259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
supperthomas merged 1 commit into from
May 12, 2025
Merged

ci: fixed the abnormal operation of ci files #10259

supperthomas merged 1 commit into from
May 12, 2025

Conversation

@kurisaW
Copy link
Member

@kurisaW kurisaW commented May 11, 2025 •
edited
Loading

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

修复存在未创建的文件操作，优化路径匹配策略

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@kurisaW kurisaW requested a review from supperthomas as a code owner May 11, 2025 00:36
@github-actions github-actions bot added the action github action yml imporve label May 11, 2025
@github-actions
Copy link

github-actions bot commented May 11, 2025 •
edited
Loading

📌 Code Review Assignment

🏷️ Tag: workflow

Path: .github
Reviewers: supperthomas Rbb666 kurisaW

Changed Files (Click to expand)
  • .github/workflows/auto-assign-reviewers.yml

📊 Current Review Status (Last Updated: 2025-05-11 01:23 UTC)

  • ⌛ supperthomas Pending Review
  • ⌛ Rbb666 Pending Review
  • ⌛ kurisaW Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@kurisaW kurisaW requested a review from Rbb666 as a code owner May 11, 2025 00:40
@github-actions github-actions bot added BSP BSP: Renesas BSP related with Renesas labels May 11, 2025
@kurisaW
Copy link
Member Author

kurisaW commented May 11, 2025 •
edited
Loading

我再次在自己的仓库测试过关键性功能：

  • 1.文件修改路径更新检测后自动生成审核名单
  • 2.已经修改过的文件并且已经任命审核者后，第二次恢复该文件为初始状态（也就是不应该触发对应的审核者），与此也不应该生成对应评论
  • 3.对于同一TAG，已经@过的审核者第二次删除@字符前缀（仅在第一次提及，避免因多次提及导致的message困扰问题）
  • 4.对于不同审核TAG，有着同一审核者，同样满足第三点规则（假设：在TAG1中maintainer1已被提及，同时第二笔commit中触发了TAG2，恰好TAG2也是为maintainer1所任命，那么对于TAG1中的评论中，maintainer1的@前缀被去除;而TAG2则会再一次@提及，因为属于新文件审查，需要重新提及）
  • 5.深路径文件匹配检测（递归检测满足MAINTAINERS的PATH规则）
  • 6.LGTM审核同步（首次评论及审核者主动删除lgtm审核评论功能）

具体可参考下面这条github-bot的评论修改记录：

但是主线上的似乎仅支持第一次的maintainer ci效果运行，不清楚是否还有其他权限问题，又或者是因为触发条件为pull_request_target，对应的branch为master，也就是说，需要主线分支更新此规则后，才能在下一次的PR创建中才能被触发

@supperthomas @Rbb666 此PR作为一个修复补丁，可以先合并，然后重新运行PR的CI测试功能

@supperthomas supperthomas merged commit 4909188 into RT-Thread:master May 12, 2025
58 checks passed
@kurisaW kurisaW deleted the patch-1 branch May 29, 2025 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@supperthomas supperthomas supperthomas approved these changes

@Rbb666 Rbb666 Awaiting requested review from Rbb666

Assignees

No one assigned

Labels

action github action yml imporve BSP: Renesas BSP related with Renesas BSP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kurisaW @supperthomas