fix(pr): stop turn refreshes from rereading review activity by donjor-agent[bot] · Pull Request #1771 · RSI-Software/t3code-hyprws

donjor-agent · 2026-10-16T11:28:39Z

🤖 claude/anthropic claude-opus-5-5 (high) · host
with peer-worker pi/openai gpt-6.1-sol (medium)

Problem

Refs #1655.
Run-end notifications made every mounted PR activity reader refetch expensive review threads.

Change

Turns advance only the status revision; mutations and explicit refreshes advance both status and activity.
Activity subscribes through the fork-only pullRequests.subscribeActivityRefreshesFork RPC and existing fork handler seam, with the same read authorization as upstream refreshes.
Upstream ws.ts is byte-identical to origin/hyprws; the upstream refresh RPC and its empty payload are unchanged.
PR-open reads, manual refresh, changed-PR activity refresh, and the watch interval remain intact.
Older servers lacking the fork RPC lose automatic activity notifications, but explicit activity reads, manual refresh, and stale reopening still work.

- refreshes({ environmentId, input: {} })
+ activityRefreshesFork({ environmentId, input: {} })

Scope and approval

Host approved implementation and ready publication, without merging.
This PR satisfies: "Run end: alone never refetches review threads".
Open condition: "Steady burn under 1,000 points/h" needs a measured run after merge (owner: host).
No live-install measurement or writes were performed.

Claim skipped at the host's direction after this refusal; no triage, classification, or reparenting was performed:

✗ Error: RSI-Software/t3code-hyprws#1655 is parentless and still Untriaged 📥, and a claim moves it off the entry Status, so Standalone 📍 would be written by nobody's judgement.
Review the open trackers, projects, and slices with ghb work, then take one of the two moves:
  home it   ghb issue edit RSI-Software/t3code-hyprws#1655 --parent ISSUE --no-relationship   — use the truthful relationship flag
  judge it  ghb issue claim RSI-Software/t3code-hyprws#1655 --standalone    — records independence from the other open work

Usage:
  ghb --caller-role ROLE --agents-file PATH issue claim ISSUE [--resume OPERATION_ID] [--repo OWNER/REPO] [--assignee LOGIN] [--project OWNER/N] [--standalone] [--allow-fail --reason TEXT]

Verification

The client regressions cover current servers, unknown-RPC failures, and missing methods: three turns produce no extra activity RPC; manual reads and stale reopening remain usable.
Current servers still deliver edit notifications; server coverage keeps the activity revision stable across 20 turns while comments, PR actions, and explicit refreshes advance it.
Authorization and instrumentation tests cover the new fork RPC.

git merge-tree --write-tree --name-only HEAD upstream/main and the same command for origin/hyprws both exit 1 for existing fork conflicts; comparing their conflict-file sets finds zero additional files on this head.
Compared refs: origin/hyprws at a1119d1167a2b7833bc11417ec065ece9f4a381d, upstream/main at cfafb4bb54d244e4612f5681aad3832ea64cb0fb.
The complete pinned fork:ci, three sequential targeted typechecks, and production build passed on the amended commit.

Grounding

Claim: with PR activity mounted, run ends send no activity read; an explicit refresh still does.

Build: local ground/wave2 4a243f4a12
Contents: this head plus four wave PR heads
Client: web dev, isolated copied state
Tab A: this PR's Timeline, mounted throughout
Tab B: a fixture thread on Claude
Probe: sent pullRequests.activity frames

Step in tab B or A	Activity frames
idle, 20s	0
turn 1 ends (B)	0
turn 2 ends (B)	0
Refresh pull requests (A)	3

Every run end calls refreshAfterTurn (RunExecutionService.ts), so both turns published the status revision.

Not grounded: a pre-fix baseline and the hourly burn; the burn stays host-owned after merge.

Model: GPT Sol (gpt-6.1-sol). Harness: Pi 1.3.0.

Fork trailers

Fork-Domain: upstream-fixes
Fork-Tier: bugfix
Fork-Upstreamable: yes

Fork-Domain: upstream-fixes Fork-Tier: bugfix Fork-Upstreamable: yes

Fork-Domain: upstream-fixes Fork-Tier: bugfix Fork-Upstreamable: yes Co-authored-by: donjor <[email protected]>

…1771)

Fork-Domain: upstream-fixes Fork-Tier: bugfix Fork-Upstreamable: yes Co-authored-by: donjor <[email protected]>

…1771)

Squashes: - 0fb81ef fix(pr): stop turn refreshes from rereading review activity (#1771) (#1771) - f0ed1cd fixup! fix(pr): stop turn refreshes from rereading review activity (#1771) (#1771) - 8db57fe fix(pr): stop turn refreshes from rereading review activity (#1771) (#1771) - ba7b379 fixup! fix(pr): stop turn refreshes from rereading review activity (#1771) (#1771) Fork-Domain: upstream-fixes Fork-Tier: bugfix Fork-Upstreamable: yes

Squashes: - 3c6db0444cf fix(pr): stop turn refreshes from rereading review activity (#1771) (#1771) - d48dfb23a29 refactor(pr): retire replacement hooks in upstream refresh paths Fork-Domain: upstream-fixes Fork-Tier: bugfix Fork-Upstreamable: yes Fork-Hook-Retired: upstream-fixes/pr-activity-refresh-turn Fork-Hook-Retired: upstream-fixes/pr-activity-refresh-stream

donjor-agent Bot assigned donjor Oct 16, 2026

rsi-software-agent Bot added the size:M label Oct 16, 2026

fix(pr): stop turn refreshes from rereading review activity

1a3339a

Fork-Domain: upstream-fixes Fork-Tier: bugfix Fork-Upstreamable: yes

donjor force-pushed the fix/1655-review-thread-refetch branch from 9485d1f to 1a3339a Compare October 16, 2026 11:45

donjor merged commit 190abd2 into hyprws Oct 16, 2026

donjor deleted the fix/1655-review-thread-refetch branch October 16, 2026 20:41

donjor added a commit that referenced this pull request Oct 18, 2026

fix(pr): stop turn refreshes from rereading review activity (#1771)

17a6bee

Fork-Domain: upstream-fixes Fork-Tier: bugfix Fork-Upstreamable: yes Co-authored-by: donjor <[email protected]>

donjor added a commit that referenced this pull request Oct 18, 2026

fix(pr): stop turn refreshes from rereading review activity (#1771)

51d5d9f

Fork-Domain: upstream-fixes Fork-Tier: bugfix Fork-Upstreamable: yes Co-authored-by: donjor <[email protected]>

donjor added a commit that referenced this pull request Oct 18, 2026

fix(pr): stop turn refreshes from rereading review activity (#1771)

5899437

Fork-Domain: upstream-fixes Fork-Tier: bugfix Fork-Upstreamable: yes Co-authored-by: donjor <[email protected]>

donjor added a commit that referenced this pull request Oct 19, 2026

fix(pr): stop turn refreshes from rereading review activity (#1771)

c3e9329

Fork-Domain: upstream-fixes Fork-Tier: bugfix Fork-Upstreamable: yes Co-authored-by: donjor <[email protected]>

donjor added a commit that referenced this pull request Oct 19, 2026

fix(pr): stop turn refreshes from rereading review activity (#1771)

d879067

Fork-Domain: upstream-fixes Fork-Tier: bugfix Fork-Upstreamable: yes Co-authored-by: donjor <[email protected]>

donjor added a commit that referenced this pull request Oct 19, 2026

fix(pr): stop turn refreshes from rereading review activity (#1771)

02265e0

Fork-Domain: upstream-fixes Fork-Tier: bugfix Fork-Upstreamable: yes Co-authored-by: donjor <[email protected]>

donjor added a commit that referenced this pull request Oct 20, 2026

fix(pr): stop turn refreshes from rereading review activity (#1771)

4e23f7b

Fork-Domain: upstream-fixes Fork-Tier: bugfix Fork-Upstreamable: yes Co-authored-by: donjor <[email protected]>

donjor added a commit that referenced this pull request Oct 20, 2026

fix(pr): stop turn refreshes from rereading review activity (#1771)

4704ec9

Fork-Domain: upstream-fixes Fork-Tier: bugfix Fork-Upstreamable: yes Co-authored-by: donjor <[email protected]>

donjor added a commit that referenced this pull request Oct 20, 2026

fix(pr): stop turn refreshes from rereading review activity (#1771)

238ff4c

Fork-Domain: upstream-fixes Fork-Tier: bugfix Fork-Upstreamable: yes Co-authored-by: donjor <[email protected]>

donjor added a commit that referenced this pull request Oct 20, 2026

fix(pr): stop turn refreshes from rereading review activity (#1771)

d5b2eef

Fork-Domain: upstream-fixes Fork-Tier: bugfix Fork-Upstreamable: yes Co-authored-by: donjor <[email protected]>

donjor added a commit that referenced this pull request Oct 20, 2026

fix(pr): stop turn refreshes from rereading review activity (#1771)

f065600

Fork-Domain: upstream-fixes Fork-Tier: bugfix Fork-Upstreamable: yes Co-authored-by: donjor <[email protected]>

donjor added a commit that referenced this pull request Oct 21, 2026

fix(pr): stop turn refreshes from rereading review activity (#1771)

65377d0

Fork-Domain: upstream-fixes Fork-Tier: bugfix Fork-Upstreamable: yes Co-authored-by: donjor <[email protected]>

donjor added a commit that referenced this pull request Oct 21, 2026

fix(pr): stop turn refreshes from rereading review activity (#1771)

d70f573

Fork-Domain: upstream-fixes Fork-Tier: bugfix Fork-Upstreamable: yes Co-authored-by: donjor <[email protected]>

donjor added a commit that referenced this pull request Oct 21, 2026

fix(pr): stop turn refreshes from rereading review activity (#1771)

0b8afed

Fork-Domain: upstream-fixes Fork-Tier: bugfix Fork-Upstreamable: yes Co-authored-by: donjor <[email protected]>

donjor added a commit that referenced this pull request Oct 21, 2026

fix(pr): stop turn refreshes from rereading review activity (#1771)

a9e8c32

Fork-Domain: upstream-fixes Fork-Tier: bugfix Fork-Upstreamable: yes Co-authored-by: donjor <[email protected]>

donjor added a commit that referenced this pull request Oct 21, 2026

fix(pr): stop turn refreshes from rereading review activity (#1771)

5cd5f5a

Fork-Domain: upstream-fixes Fork-Tier: bugfix Fork-Upstreamable: yes Co-authored-by: donjor <[email protected]>

donjor added a commit that referenced this pull request Oct 22, 2026

fix(pr): stop turn refreshes from rereading review activity (#1771)

8f1ca45

Fork-Domain: upstream-fixes Fork-Tier: bugfix Fork-Upstreamable: yes Co-authored-by: donjor <[email protected]>

donjor added a commit that referenced this pull request Oct 22, 2026

fix(pr): stop turn refreshes from rereading review activity (#1771)

6b3aa50

Fork-Domain: upstream-fixes Fork-Tier: bugfix Fork-Upstreamable: yes Co-authored-by: donjor <[email protected]>

donjor added a commit that referenced this pull request Oct 23, 2026

fix(pr): stop turn refreshes from rereading review activity (#1771)

59bc0dd

Fork-Domain: upstream-fixes Fork-Tier: bugfix Fork-Upstreamable: yes Co-authored-by: donjor <[email protected]>

donjor added a commit that referenced this pull request Oct 24, 2026

fix(pr): stop turn refreshes from rereading review activity (#1771)

0ff72c1

Fork-Domain: upstream-fixes Fork-Tier: bugfix Fork-Upstreamable: yes Co-authored-by: donjor <[email protected]>

donjor added a commit that referenced this pull request Oct 27, 2026

fix(pr): stop turn refreshes from rereading review activity (#1771)

17f13cc

Fork-Domain: upstream-fixes Fork-Tier: bugfix Fork-Upstreamable: yes Co-authored-by: donjor <[email protected]>

donjor added a commit that referenced this pull request Oct 27, 2026

fixup! fix(pr): stop turn refreshes from rereading review activity (#…

928e4be

…1771)

donjor added a commit that referenced this pull request Oct 27, 2026

fix(pr): stop turn refreshes from rereading review activity (#1771)

8db57fe

Fork-Domain: upstream-fixes Fork-Tier: bugfix Fork-Upstreamable: yes Co-authored-by: donjor <[email protected]>

donjor added a commit that referenced this pull request Oct 27, 2026

fixup! fix(pr): stop turn refreshes from rereading review activity (#…

fb50693

…1771)

Navigation Menu

Repository navigation

fix(pr): stop turn refreshes from rereading review activity - #1771

fix(pr): stop turn refreshes from rereading review activity#1771
donjor merged 1 commit into
hyprwsfrom
fix/1655-review-thread-refetch

donjor-agent Bot commented Oct 16, 2026 •

edited

Loading

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

donjor-agent Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Change

Scope and approval

Verification

Grounding

Fork trailers

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

donjor-agent Bot commented Oct 16, 2026 •

edited

Loading