Skip to content

vp check is red on trunk: eight files the rebase repair left unformatted [✨#663] #712

Description

@donjor-agent

πŸ€– claude/anthropic claude-opus-5 (high)

Part of RSI-Software/t3code-hyprws#663.

Origin: found while landing the RSI-Software/t3code-hyprws#656 wave; Check stayed red on every wave pull request after the knip cause was fixed.

Check is a required status on the hyprws ruleset, and it is red on clean trunk for a second, independent reason. vp run knip:check now passes (RSI-Software/t3code-hyprws#707); the job then reaches vp check and fails there.

Reproduced at f1ace7da851 with no local changes:

error: Formatting issues found
.github/fork-workflow-reviews.json
apps/desktop/src/preview/WindowPolicy.ts
apps/mobile/src/features/terminal/terminalMenu.test.ts
apps/server/src/provider/Layers/CodexAdapter.ts
apps/server/src/pullRequest/PullRequestService.test.ts
apps/web/src/components/ThreadTerminalDrawer.tsx
docs/user/providers-codex.md
scripts/fork-delta.ts

Found formatting issues in 8 files. Run `vp check --fix` to fix them.

Six of the eight are upstream files the fork edits, one is a fork-owned script, and one is a fork-owned workflow record. That distribution says the writer was the rebase repair pass, not a human edit: the sync walk rewrites conflicted hunks and re-lands fork changes without running the repository formatter over what it wrote, so a walk can leave trunk red on a required status while reporting a clean repair.

Two things are wanted here.

  1. Make Check green on trunk again. vp check --fix is the whole mechanical fix.
  2. Stop the recurrence, per the fork rule that every action taken from the churn ledger ships the guard that prevents it: the sync walk should run the repository's own format check over the files it rewrote, and refuse or repair before it reports the walk clean.

Item 2 is the load-bearing half. Item 1 alone leaves the next walk free to do it again.

Note for whoever takes this: vp check --fix also applies lint autofixes, touching eight files beyond the eight the formatter names, including scripts/fork-sync.ts. Establish which of those the Check job actually requires before widening the diff. Every extra file is churn charged to a fork domain and a rebase conflict for the pull requests already open on this chain.

Relates to RSI-Software/t3code-hyprws#707.

Relates to #707.

Activity

  1. changed the title [-]vp check is red on trunk: eight files the rebase repair left unformatted [✨#656][/-] [+]vp check is red on trunk: eight files the rebase repair left unformatted [✨#663][/+] on Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    dxdeveloper experience, CLIs, skills

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions