Repository navigation
Closed
Copy link
Labels
dxdeveloper experience, CLIs, skillsdeveloper experience, CLIs, skills
Description
🤖 claude/anthropic claude-opus-5-5 (high)
Problem
The whole-series scan grandfathers legacy findings, and nothing ever pays them down.
| Part | Evidence |
|---|---|
| Baseline | resolveBaselineKeys in scripts/fork-scan.ts: with --replay-of and --since equal to --target, a finding already on the trunk renders advisory |
| Origin | c341365 fix(fork): sync battery fails only on findings the replay introduced; 197 legacy findings had turned every sync red |
| Fold | proves tree-equal, so it never touches the files that carry a finding |
| PR CI | scans only its own commits, so an old finding is never seen again |
| Result | the 2026-10-02 sync reported 172 findings, all advisory |
Inventory
Merge base 094fb23 (v0.0.45-nightly.20261001.2552), head dd89a3c:
vp run fork:scan --head origin/hyprws --target <merge-base> --since <merge-base> \
--replay-of origin/hyprws --no-typecheckhistorical: 172 finding(s) already on origin/hyprws against 094fb230e90…, advisory
| Kind | Count | Owner |
|---|---|---|
upstream-test: fork blocks in an upstream test file |
93 | 28 commits |
upstream-test: changed or removed upstream test lines |
41 | 26 commits |
replaced-export |
10 | 6 commits |
additive:tests: upstream test lines gone, no sibling |
28 files, 132 lines | tree-level |
By domain
| Domain | upstream-test |
replaced-export |
|---|---|---|
| upstream-fixes | 28 | 0 |
| custom-agents | 23 | 2 |
| zmux-estate | 21 | 0 |
| multi-window | 19 | 1 |
| fork-meta | 11 | 0 |
| github-issues | 11 | 0 |
| worktrunk-hooks | 7 | 1 |
| workspace-files | 4 | 1 |
| backend-attach | 2 | 5 |
| browser-bookmarks | 2 | 0 |
| distribution | 2 | 0 |
| markdown-editing | 2 | 0 |
| thread-ordering | 2 | 0 |
additive:tests area |
Files |
|---|---|
apps/server |
11 |
apps/web |
8 |
apps/desktop |
5 |
apps/mobile, packages/client-runtime, packages/contracts, scripts |
1 each |
Decision
- Pay each finding down in the commit that owns it.
- Remove the baseline: any finding refuses.
| Finding | Pay-down |
|---|---|
| Fork test block | move to the .fork. sibling |
| Changed upstream test line | restore it |
| Replaced export | extend from a fork-owned sibling |
Side defect, moot on removal: the gate compares --since and --target as strings, so a short sha against a full sha silently disables the baseline.
scripts/fork-ci.ts still prints replay-of in its header line; it goes with the baseline.
Close conditions
- Inventory: the scan reports 0 findings
- Baseline:
resolveBaselineKeysremoved - Guard: a pre-existing finding fails the scan
Origin: the 2026-10-02 fork sync reported 172 grandfathered findings as advisory.
Carried from #689
Triage on 2026-10-14 folded the upstream-tests invariant in.
- In-place edits: 0 on the next walk
Metadata
Metadata
Assignees
Labels
dxdeveloper experience, CLIs, skillsdeveloper experience, CLIs, skills
Activity
[-]pay down grandfathered scan findings, then remove the baseline[/-][+]pay down grandfathered scan findings, then remove the baseline [✨#689][/+]donjor-agent commentedon Oct 2, 2026
Plan settled; work starts with the tooling batch.
The inventory on 0e13bec is unchanged at 172 findings. They split into three groups:
fixup!PRs in seven file-cluster batchesDecisions
fork-foldaccepts a non-repair commit split across owners when each owner cites it underSquashes:DesktopWindow.test.tsandserver.test.tsblocks move to register-function siblings; the stale deferral text goesfixup! <owner subject>: squash landing collapses a multi-commit PR into one commitserverRuntimeState,EnvironmentResourceNotFoundReasonOrder
prove.fix(fork): scan skips restored upstream test openers; folds may split…
fix(fork): scan skips restored upstream test openers; folds may split…
fix(fork-sync): a squash-landed fixup! pull request folds at the next…
fix(fork): forkSupersedes names wrapped and each-table upstream titles (
fixup! test(fork): complete fork-owned test sibling migration (#1533)
fixup! fix(server): keep pull requests on origin (#1535)
fixup! test(fork): move fork test blocks into fork-owned siblings (#1536
fixup! fix(server): follow external workspace symlinks globally (#66) (…
269 remaining items
refactor(fork-meta): fork scan refuses every finding; the replay base…
fix(fork): scan skips restored upstream test openers; folds may split…
fix(fork-sync): a squash-landed fixup! pull request folds at the next…
fix(fork): forkSupersedes names wrapped and each-table upstream titles (
fix(fork): folds list squash-landed fixups as members (#1591)
fix(fork): a fold keeps a split piece's repair line when its owner en…
refactor(fork-meta): fork scan refuses every finding; the replay base…
fix(fork): scan skips restored upstream test openers; folds may split…
fix(fork-sync): a squash-landed fixup! pull request folds at the next…
fix(fork): forkSupersedes names wrapped and each-table upstream titles (
fix(fork): folds list squash-landed fixups as members (#1591)
fix(fork): a fold keeps a split piece's repair line when its owner en…
refactor(fork-meta): fork scan refuses every finding; the replay base…
fix(fork): scan skips restored upstream test openers; folds may split…
fix(fork-sync): a squash-landed fixup! pull request folds at the next…