Skip to content

Commit fe0a298

Browse files
donjor-agent[bot]rsi-pr-agent
authored andcommitted
fix(web): the palette's Link GitHub issue item matches its own title (#1617)
> 🤖 claude/anthropic claude-opus-5-5 (high) ## Problem The palette's "Link GitHub issue to thread" item does not match its own title. Its search terms lack `to` and `thread`, and the filter matches terms only. ![Before: full title finds nothing](https://github.com/user-attachments/assets/7d640fb7-f09d-4095-b7bc-f9ebcf3674e6) ## Change The terms become `link issue to thread`, `github`, `attach`, `track`. Every query that matched before still matches. ## Scope and approval Follow-up F3 from the `.2638` UAT, #1607, accepted by the maintainer. The UAT body proposed adding `thread` alone; that still misses `to`. Upstream's "Link pull request to thread" has the same gap; this leaves it alone. ## Verification | check | result | | --- | --- | | New test: full title and short query | pass; full title fails without the fix | | `CommandPalette.logic.fork.test.ts` | 7 passed | | `vp run fork:ci` | exit 0; scripts 731/731 | | After screenshot | not taken; the test drives the real filter | Claude Opus 5.5 in Claude Code, inside T3 Code. ## Fork trailers Fork-Domain: github-issues Fork-Tier: qol Fork-Upstreamable: no <!-- gh-bot:attest {"v":2,"repo":"RSI-Software/t3code-hyprws","ref":"hyprws@8c2aafa","build":"252611418","agents":[{"role":"host","iface":"claude","provider":"anthropic","model":"claude-opus-5-5","effort":"high","harness":"[email protected]","session":"da5d3d04239a"}],"ts":"2026-10-04T02:18:40Z"} -->
1 parent 4738679 commit fe0a298

2 files changed

Lines changed: 28 additions & 3 deletions

File tree

‎apps/web/src/components/CommandPalette.fork.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ export function buildLinkGitHubIssueActionItemFork(
6262
return {
6363
kind: "action",
6464
value: "action:link-github-issue",
65-
searchTerms: ["link", "issue", "github", "attach", "track"],
65+
searchTerms: ["link issue to thread", "github", "attach", "track"],
6666
title: "Link GitHub issue to thread",
6767
icon: <LinkIcon className={ITEM_ICON_CLASS} />,
6868
run: async () => {

‎apps/web/src/components/CommandPalette.logic.fork.test.ts‎

Lines changed: 27 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,13 @@
1-
import { EnvironmentId, ProjectId } from "@t3tools/contracts";
1+
import { EnvironmentId, ProjectId, ThreadId } from "@t3tools/contracts";
22
import { describe, expect, it } from "vite-plus/test";
33

4-
import { browseInputEndPaddingClass, type CommandPaletteActionItem } from "./CommandPalette.logic";
54
import {
5+
browseInputEndPaddingClass,
6+
filterCommandPaletteGroups,
7+
type CommandPaletteActionItem,
8+
} from "./CommandPalette.logic";
9+
import {
10+
buildLinkGitHubIssueActionItemFork,
611
refreshNewThreadInViewFork,
712
scopePaletteProjectEntriesFork,
813
withProjectScopeToggleFork,
@@ -90,3 +95,23 @@ describe("palette project scope", () => {
9095
);
9196
});
9297
});
98+
99+
describe("link GitHub issue action", () => {
100+
const linkItem = buildLinkGitHubIssueActionItemFork(
101+
{ environmentId: EnvironmentId.make("local"), id: ThreadId.make("thread-1") },
102+
{ threadIssues: true },
103+
);
104+
const search = (query: string) =>
105+
filterCommandPaletteGroups({
106+
activeGroups: [{ value: "actions", label: "Actions", items: linkItem ? [linkItem] : [] }],
107+
query,
108+
isInSubmenu: false,
109+
projectSearchItems: [],
110+
threadSearchItems: [],
111+
}).flatMap((group) => group.items.map((item) => item.value));
112+
113+
it("matches its own title and its short query", () => {
114+
expect(search("link github issue to thread")).toEqual(["action:link-github-issue"]);
115+
expect(search("link github issue")).toEqual(["action:link-github-issue"]);
116+
});
117+
});

0 commit comments

Comments
 (0)