You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit e2e24ff
Browse filesBrowse the repository at this point in the historyBrowse files
feat(web): simplify the window project chooser (#1669)
## Problem
The project chooser's separate mode controls did not fit the app's native project list.
## Change
Restores the icon-bearing **All projects** row and places the standard **Exclude** Switch at its right edge, keeping the current popup width.
All projects resets picks and exclusion; the Switch retains picks while changing their meaning; clearing included picks shows **No projects**.
Explicit No projects also publishes an empty desktop project scope.
Stacked above #1663.
The maintainer approved this design after VMON-3 review.
Shared web/desktop chooser and client filter helpers; mobile UI, providers, and wire contracts are unchanged.
**Preserved defect:** excluding every project still makes the new-thread picker list all excluded projects.
This parent defect remains at the maintainer's request.
## Verification
Head: `69eb05f7ba6205a4dae4ea903374e855365255ef`.
Parent: `486b691b3eebbfe4b17960c9a9d6cdebcbef1a20`.
| Check | Result |
| --- | --- |
| Chooser and window-scope tests | Exit 0, 24 tests |
| Web typecheck and production build | Exit 0 each |
| `vp run fork:ci` on this head | Exit 0 |
| React Doctor, changed files | Exit 0, no findings; score 66/100 |
| Real Chrome on VMON-3 | Desktop, 375px, pointer, Tab/Space, Home/Enter reset |
| Search, modes, counts, All/None | Pass; None survives reload |
| All-six-excluded picker | Known failure reproduced and preserved |
| Required GitHub checks at 69eb05f | All eight passed |
Native Electron, native mobile, and remote/relay/tunnel connections were not exercised.
T3 preview was unavailable because of host AppArmor; Hypr verification was explicitly authorized.
<details>
<summary>Aftercare findings and limits</summary>
The automated report is still marked reviewing older head `6b3d782`; its last completed findings refer to `c6a7e81`.
No automated review of this head is claimed.
| Item | Current source/evidence |
| --- | --- |
| A1: None reported as all projects | Fixed in `windowProjects.fork.ts`, with empty inclusion/publication regressions |
| A2: unequal segmented controls | Superseded by the native Switch design; narrow layout inspected |
| A3: all-excluded picker fallback | Intentionally preserved; reproduced with all six fixtures |
Parent aftercare also remains in progress on `486b691`; all eight parent required checks passed.
No aftercare job, bot-owned report, or other owner's session was modified.
</details>
<details>
<summary>Before and after</summary>
| Original parent chooser at 705e594 | Approved chooser at 69eb05f |
| --- | --- |
|  |  |
</details>
<details>
<summary>Current-head Hypr recording and receipts</summary>
Open the chooser, search gh, pick gh-bot and zmux, see **Projects: 2 selected**, exclude both, see **Projects: All except 2**, switch back, and reset All projects.
The clean checkout at the full head above served the actual changed chooser from isolated worktree state on port 5936.
https://github.com/user-attachments/assets/0c52e249-b643-4798-9829-7c1fd61ea41f
Hypr take `rec-e04f.e1`, window `18000197`, VMON-3, workspace 103.
H.264, 380x480, 11.2 seconds, 30fps, no audio or speed changes.
Retained raw 9.8-21.0 seconds; removed opening 0-9.8 and trailing 21.0-21.07 idle; no internal cuts; crop `380:480:0:86`.
Browser-only masking hides thread content and main; the chooser and its native count tooltips are unchanged.
Project names and icons remain visible.
The published attachment was downloaded through `ghb attachment get`, matched byte-for-byte, and played in Chrome to `ended=true`, time/duration 11.2, error null.
SHA-256: `a98f972b9d82c9dc7fa5d65f573c2df5a8b2bd0a7879793c7bc7fa766f8ee68b`.
GitHub's embedded player is unverified; no accepted peer or grounder handoff is claimed.
The CLI returned page `pg-29`, rather than a lease UUID; no strict accept-envelope validation is claimed.
Actual tool-result receipts:
| Result | Observed operation |
| --- | --- |
| `102f5a`, exit 0 | Read hypr, chrome-debug, frontend-design, ui, zmux SKILL.md contents |
| `546914`, exit 0 | Read gh-bot, gh-post, writing-md SKILL.md contents |
| `076658`, exit 0 | Read evidence upload/readback guide and gh-post style |
| `cf683b`, exit 0 | Read gh-bot, gh-tracking, gh-post before publication |
| `7c6c78` / `6870b2`, exit 0 | Hypr capture start/stop |
| `2c19fb`, exit 0 | Trim/crop final recording and hash |
| `b7b1bf`, exit 0 | Upload current-head screenshot and recording |
| `54949f`, exit 0 | Download and byte comparison of published recording |
These are actual read/result receipts, rather than skill loading inferred from screenshots.
Body publication uses the active Codex harness directly because managed-terminal publishing previously lacked caller provenance; no identity bypass is used.
</details>
Model: GPT-6.1-Sol. Harness: Codex.
## Fork trailers
Squashes:
- eb8e361 feat(web): simplify the window project chooser (#1669) (#1669)
- 70f48e8 fixup! feat(web): simplify the window project chooser (#1669) (#1669)
Fork-Domain: workspaces
Fork-Tier: qol
0 commit comments