You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit dd1b537
Browse filesBrowse the repository at this point in the historyBrowse files
authored and
rsi-pr-agent
committed
fix(fork-sync): the job always decides and runs from an rsi-pr-agent checkout (#1854)
## Problem
The first live `fork-sync` job ([run_a24855ae](https://agent.rsi.nz/runs/run_a24855ae4dc78bc3194b411b85e9c7ea)) resolved about 17 rebase stops, then reported `blocked` at `b2a94da9bd` (desktop wheel zoom) after 19 of its 45 minutes.
- **Rule:** "Unsure: report `blocked`"
- **Root:** driver took `/home/agent/commits`
- **`vp`:** not on PATH for worktree setup
An rsi-pr-agent job keeps its git dir outside the work tree, so `dirname(--git-common-dir)` is not the checkout.
The job worked around both by cloning a sibling checkout, which also lost its commit identity.
## Change
- **Job mode:** decides every seam; never blocks
- **Default:** upstream stands; port at the tip
- **Failed port:** Retire, listed under `Verify:`
- **Summary:** ends with what to test
- **Driver:** separate git dir → `--show-toplevel`
- **`vp`:** Job mode links it outside `node_modules`
## Scope and approval
Part of #1841, which now has no human-review step: candidate CI gates landing.
## Verification
- [x] **New test:** separate git dir blocks, then applies
- [x] **Without the fix:** it fails
- [x] `vp test run scripts/fork-sync.test.ts` → 79 ok
- [x] `vp run fork:ci` → exit 0
Not yet proven: a live job deciding a seam it would have blocked on; the next sync proves it.
Claude Opus 5.5 in Claude Code.
## Fork trailers
Squashes:
- 83669bb fix(fork-sync): the job always decides and runs from an rsi-pr-agent checkout (#1854) (#1854)
- a0ab51c fixup! fix(fork-sync): the job always decides and runs from an rsi-pr-agent checkout (#1854) (#1854)
Fork-Domain: fork-meta
Fork-Tier: bugfix
Fork-Upstreamable: no
Co-authored-by: donjor <[email protected]>
0 commit comments