You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit ca00d62
Browse filesBrowse the repository at this point in the historyBrowse files
authored and
rsi-pr-agent
committed
fix(fork): forkSupersedes names wrapped and each-table upstream titles (#1532)
Replaces #1511, which GitHub closed when a host push briefly set its branch to trunk. Same commits, rebased onto `b98ba3ed105`; the combined fold proof of all B2 fixups was rerun there: no stops, tree-equal.
## Problem
`forkSupersedes` cannot name an upstream case whose title prettier wrapped onto the next line (`it.effect(` then `"title"`), or an `.each` table case (`it.effect.each([...])(`).
The scan refuses the declaration ("does not carry"), and the authoring guard excuses none of the removed lines.
This blocks the #1493 B2 supersedes in `RepositoryIdentityResolver.test.ts` and `ProjectSetupScriptRunner.test.ts`.
## Change
- `scripts/lib/fork-supersedes.ts` owns one case-opener parse, `caseOpeners`.
- It reads a same-line title, a title on the line after a bare opener, and a one-line `.each(...)` table.
- `caseSourceLines` returns one case's source lines.
- `fork-scan-authoring.ts` and `fork-additive-gate.ts` drop their copies of the title regex and the case walk, and call `caseSourceLines`.
- The authoring module doc had an import spliced into it; the doc is rejoined and the stale "kept local" note goes.
## Scope and approval
Part of #1493 (batch B2 tooling prerequisite, host decision).
B2 supersede PRs stack on this one.
## Verification
```text
vp test run scripts/lib/fork-supersedes.test.ts scripts/fork-scan-gates.test.ts scripts/lib/fork-additive-gate.test.ts → exit 0 (57 passed)
new guard case on the old parser → 1 failed (as expected)
tsc --noEmit (scripts) → exit 0
vp lint <touched files> → exit 0
vp run fork:ci → exit 0
```
Rebase scan (`--head HEAD --target <v0.0.45-nightly.20261002.2561> --since <same> --replay-of origin/hyprws --no-typecheck`): 95 historical findings before and after, none new.
Model: Claude Opus 5.5, Claude Code (T3 Code thread).
## Fork trailers
Squashes:
- 62bcd0c fix(fork): forkSupersedes names wrapped and each-table upstream titles (#1532) (#1532)
- cdac57a fixup! fix(fork): forkSupersedes names wrapped and each-table upstream titles (#1532) (#1532)
Fork-Domain: fork-meta
Fork-Tier: core
Fork-Upstreamable: no
Co-authored-by: donjor <[email protected]>
'it.effect(\n "a title long enough that prettier wraps it",\n () => Effect.sync(() => expect(keep).toBe(2)),\n);\n';
563
+
constsibling=
564
+
'forkSupersedes({ upstream: "apps/web/src/thing.test.ts > a title long enough that prettier wraps it", reason: "the fork inverts it", commit: "abc1234" });\n'+
0 commit comments