Repository navigation
Commit c20d6ef
fix(web): client-only Connections hides managed-server controls (#1867)
## Problem
In client-only mode, Connections shows controls for a server this desktop does not manage: Local environment, Network access, and Tailscale HTTPS.
The upstream gate keys on `environment:maintain`, which a standard pairing grants, and the local-environment flag defaults to on.
## Change
New gate `canManageLocalBackendFork` requires all three:
- `environment:maintain` scope
- not client-only
- local environment on
**Callers:**
- Connections rows
- Settings search
- `LocalEnvironmentSetting`: off in client-only
**Rename:** one fork file holds both client-only gates.
```text
apps/web/src/components/settings/
└── connectionsSessionScopes.fork.ts → connectionsClientOnly.fork.ts
```
Upstream edits are one-line fork hooks; the managed path is unchanged.
## Scope and approval
Closes #1773; the human chose a fork fix.
- [ ] **Hidden:** all three rows in client-only
- [ ] **Kept:** managed desktop still shows them
**Also hidden in client-only:** the Version row, behind the same gate.
**Known gap, left as is:** the `local-environment` search item still lists in client-only, then opens Connections without the row.
Tagging it `localBackendManagementOnly` would also hide the way back when a managed desktop turns its local environment off.
## Verification
Dev desktop on the worktree `.t3`; client-only attached a separate `vp run dev:server` on `:14289`.
**Client-only, before** (pre-fix sources): all three rows shown

**Client-only, after:** rows gone

**Managed, after:** rows kept

**Checks:**
- Gate tests: 8/8 pass
- `vp run check:changed` → exit 1
- two failing tests, outside this diff
- `GitManager.test.ts`: CLAUDE.md case, fails alone
- `markdownPipeline.browser.test.ts`: passes alone
- `vp run fork:ci` → exit 0
Claude Opus 5.5, Claude Code in T3 Code.
## Fork trailers
Fork-Domain: backend-attach
Fork-Tier: bugfix
Fork-Upstreamable: no
Co-authored-by: donjor <[email protected]>1 parent 9585bef commit c20d6ef
6 files changed
Lines changed: 63 additions & 27 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
29 | | - | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
30 | 32 | | |
31 | 33 | | |
32 | 34 | | |
| |||
292 | 294 | | |
293 | 295 | | |
294 | 296 | | |
295 | | - | |
| 297 | + | |
296 | 298 | | |
297 | 299 | | |
298 | 300 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
3 | 4 | | |
4 | 5 | | |
5 | 6 | | |
| |||
23 | 24 | | |
24 | 25 | | |
25 | 26 | | |
26 | | - | |
| 27 | + | |
27 | 28 | | |
28 | 29 | | |
29 | 30 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
10 | 13 | | |
11 | 14 | | |
12 | 15 | | |
| |||
53 | 56 | | |
54 | 57 | | |
55 | 58 | | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
| |||
48 | 49 | | |
49 | 50 | | |
50 | 51 | | |
51 | | - | |
| 52 | + | |
52 | 53 | | |
53 | 54 | | |
54 | 55 | | |
| |||
0 commit comments