Skip to content

Commit b8105b3

Browse files
committed
chore(fork-sync): repair additive after v0.0.41-nightly.20260910.1473
The replay is not purely additive: `fix(web): upload media in pull request descriptions` re-adds a hunk upstream deleted. ``` readded apps/web/src/components/pullRequest/PullRequestSummaryTab.tsx: re-adds 1 hunk(s) upstream deleted number: detail.number, projectId: detail.projectId, repository: detail.repository, ``` The fork commit builds the description editor's attachment reference from three `detail` fields. `feat(pull-requests): link multiple pull requests to threads (pingdotgg#10839)` deleted that exact triple from `CommentComposer` and replaced it with a spread of the component's `reference` prop, which now also carries `host`. The fork hunk predates that prop, so the triple it writes is the shape upstream had already retired. The attachment now takes the same `reference` every other call site in the file already passes. `PullRequestMarkdownEditor` types the field as `PullRequestRef`, so this is the identical value by a shorter route, and it gains the host the fork hunk could not name. Fork behaviour is unchanged: an attachment upload is still offered only for a connected, host-backed description. The walk's own `dropReaddedLines` declined this one because the lines come back inside a fork-owned block rather than as a restored upstream hunk, so the fix is the walk's repair commit written by hand. | Check | Result | | --- | --- | | `vp run typecheck` in `apps/web` | no `error TS` | Refs #733 Fork-Domain: upstream-fixes Fork-Tier: bugfix Fork-Upstreamable: no Fork-Repair: v0.0.41-nightly.20260910.1473
1 parent 330658f commit b8105b3

1 file changed

Lines changed: 1 addition & 5 deletions

File tree

‎apps/web/src/components/pullRequest/PullRequestSummaryTab.tsx‎

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -850,11 +850,7 @@ export function PullRequestSummaryTab({
850850
detail.capabilities.attachments === true && Option.isSome(preparedConnection)
851851
? {
852852
httpBaseUrl: preparedConnection.value.httpBaseUrl,
853-
reference: {
854-
projectId: detail.projectId,
855-
repository: detail.repository,
856-
number: detail.number,
857-
},
853+
reference,
858854
}
859855
: undefined
860856
}

0 commit comments

Comments
 (0)