Repository navigation
Commit b452743
docs(fork): document hook marker span; guard names the comment fix (#1497)
## Problem
"Marking a hook" in `docs/fork/internals/fork-delta.md` listed a `FORK_HOOKS` manifest that no longer exists and never said what span a trailing marker covers.
Authors learned the walk from guard refusals: the 2026-10-02 sync hit four on one `apps/desktop/src/preview/Manager.ts` hook.
## Change
| Change | Result |
| --- | --- |
| Walk rule | trailing marker covers its whole statement |
| Comment placement | table plus refused and accepted examples |
| Manifest row | removed |
| Reflow row | scoped to `fork-hook-seam` |
| Guard message | all-comment refusal: move the comment inside the statement or drop it |
| Walk | unchanged |
## Scope and approval
Closes #1492, implementing its Decision table only.
## Close conditions
- [x] **Walk rule:** documented with examples
- [x] **Manifest row:** removed
- [x] **Reflow row:** names its guard
- [x] **Message:** comment-only refusal names the fix
- [x] **Guard:** a test covers the new message
## Verification
```text
vp test run scripts/lib/fork-hook-guard.test.ts scripts/lib/fork-hooks.test.ts → exit 0 (33 passed)
vp run fork:ci → exit 0
```
`parseForkHookMarkers` on the three documented placements gave the spans the doc states:
```text
comment above [2, 6] comment outside
comment after => [3, 6] const line and comment outside
comment in args [1, 6] whole statement
```
Claude Code, claude-opus-5-5.
## Fork trailers
Fork-Domain: fork-meta
Fork-Tier: qol
Fork-Upstreamable: no
Co-authored-by: donjor <[email protected]>1 parent dc4178b commit b452743
3 files changed
Lines changed: 78 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
88 | | - | |
| 88 | + | |
89 | 89 | | |
90 | | - | |
91 | 90 | | |
92 | 91 | | |
93 | 92 | | |
94 | 93 | | |
95 | 94 | | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
96 | 133 | | |
97 | 134 | | |
98 | 135 | | |
| |||
110 | 147 | | |
111 | 148 | | |
112 | 149 | | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
122 | 159 | | |
123 | 160 | | |
124 | 161 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
35 | 56 | | |
36 | 57 | | |
37 | 58 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
57 | 60 | | |
58 | 61 | | |
59 | 62 | | |
| |||
113 | 116 | | |
114 | 117 | | |
115 | 118 | | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
116 | 124 | | |
117 | | - | |
| 125 | + | |
118 | 126 | | |
119 | 127 | | |
120 | 128 | | |
| |||
0 commit comments