You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit ac05889
Browse filesBrowse the repository at this point in the historyBrowse files
fix(desktop): a placed window maps on its workspace before it maximizes
## What Changed
- `WindowPlacement.placeAtMapFork` takes `maximize` and calls `window.maximize()` after `showInactive()`, so the window is already mapped under its staged workspace rule.
- `DesktopWindow.ts`: the placement branch runs before the upstream `mainWindowMaximized` maximize. That maximize and the focused reveal now run only on the path with no placement, which is unchanged.
- New test: a placed maximized window records `stage-rule`, `show-inactive`, `maximize` in that order, with no `show` and no `focus`.
## Why
Electron's `maximize()` shows a hidden window. The reveal trigger called it before the placement staged the Hyprland rule, so the window mapped on the focused workspace, then moved. On Hyprland `mainWindowMaximized` is normally `true`. A control run with it `false` mapped correctly and did not move.
Dev agent placement and restored windows both use `placeAtMapFork`, so this fix covers both. On a window that is already visible, Chromium's maximize only requests the maximized state and does not activate the window. The packaged re-run still has to prove that Hyprland keeps focus where it is.
Closes#261
- [ ] A project window maps on its intended workspace at first map, with no later move
- [ ] Neither monitor changes its active workspace when a project window opens
## Checklist
- [x] This PR is small and focused
- [x] I explained what changed and why
- [ ] I included before/after screenshots for any UI changes
- [ ] I included a video for animation/interaction changes
Claude Code, claude-opus-5-5.
## Fork trailers
Squashes:
- c756f91 fix(desktop): a placed window maps on its workspace before it maximizes
- 3d3cb5a fix(desktop): windows opened together each claim their own Hyprland client
- 8f8346c fix(desktop): a placed window maps on its workspace before it maximizes
- faa53bd refactor(multi-window): createWindow seams become marked insertions (#1811) (#1811)
Fork-Domain: multi-window
Fork-Tier: core
0 commit comments