Repository navigation
Commit a75bcda
test(github-issues): prove the upstream app still reads a fork server (#1452)
## What Changed
A test decodes fork-encoded payloads with the upstream contracts, so a fork server provably stays readable by the upstream app.
| Payload | Upstream result |
| --- | --- |
| Shell snapshot and `thread-upserted` with `issues` | decodes; `issues` dropped |
| Thread detail snapshot | decodes |
| Environment descriptor with fork capabilities | decodes; fork flags dropped |
| `thread.issue-linked` and every fork-only event type | rejected |
The last row is why the server must never send a fork event to an upstream client.
A server case now proves that rule on resume: only upstream message events and the sync marker arrive, live and on replay.
| File | Change |
| --- | --- |
| `scripts/upstream-client-compat.fork.test.ts` | new; upstream contracts from `git merge-base HEAD upstream/main` |
| `apps/server/src/ws.threadIssues.fork.suite.ts` | resume-from-sequence case |
| `.github/workflows/hyprws-ci.yml` | Test Scripts job fetches upstream history |
| `docs/fork/internals/fork-development.md` | no fork mobile build; compatibility rule |
| `docs/fork/user/managed-terminals.md` | drops two mobile claims |
## Why
The fork ships no mobile build; users run the upstream app against a fork server.
Nothing proved the linked-issue wire additions left that app working.
This is part of #1430.
The test reads upstream at the merge-base, today `v0.0.44`, the tag store builds come from.
## Checks
```text
vp test run scripts/upstream-client-compat.fork.test.ts → exit 0 (3 tests)
vp test run apps/server/src/server.test.ts → exit 0 (213 tests)
tsc --noEmit (scripts, apps/server) → exit 0
vp run knip:check → exit 0
vp run fork:ci → exit 0 (60 files, 679 tests)
```
## Evidence
The compat test against the upstream `v0.0.44` contracts.

## Close conditions
Refs #1435
The **Upstream app** condition stays open: it needs the upstream Android app in an emulator.
| Condition | Evidence |
| --- | --- |
| Shell | shell and thread-detail cases |
| Config | environment descriptor case |
| Events | fork-only rejection case; server resume case |
| Docs | fork guide Mobile rule |
| Rule | fork guide compatibility table |
## Checklist
- [x] This PR is small and focused
- [x] I explained what changed and why
- [x] I included before/after screenshots for any UI changes
- [x] I included a video for animation/interaction changes
No UI or motion changed.
Opus 5.5 via Claude Code in T3 Code.
## Fork trailers
Squashes:
- 50e9c9e test(github-issues): prove the upstream app still reads a fork server (#1452) (#1452) (#1453)
- e4a3774 fixup! test(github-issues): prove the upstream app still reads a fork server (#1452) (#1452)
- d17fd1f test(github-issues): prove the upstream app still reads a fork server (#1452) (#1452) (#1453)
- 4c172af test(github-issues): the upstream-client compat check reads V2 wire schemas
- c827832 test(github-issues): the upstream-client compat check reads issue links on V2 metadata events
Fork-Domain: github-issues
Fork-Tier: qol
Fork-Upstreamable: no1 parent eaf2f16 commit a75bcda
3 files changed
Lines changed: 584 additions & 2 deletions
File tree
- .github/workflows
- docs/fork/user
- scripts
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
255 | 255 | | |
256 | 256 | | |
257 | 257 | | |
| 258 | + | |
258 | 259 | | |
259 | 260 | | |
260 | 261 | | |
| |||
273 | 274 | | |
274 | 275 | | |
275 | 276 | | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
276 | 284 | | |
277 | 285 | | |
278 | 286 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
| 45 | + | |
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| |||
0 commit comments