Skip to content

Commit a75bcda

Browse files
donjor-agent[bot]rsi-pr-agent
authored andcommitted
test(github-issues): prove the upstream app still reads a fork server (#1452)
## What Changed A test decodes fork-encoded payloads with the upstream contracts, so a fork server provably stays readable by the upstream app. | Payload | Upstream result | | --- | --- | | Shell snapshot and `thread-upserted` with `issues` | decodes; `issues` dropped | | Thread detail snapshot | decodes | | Environment descriptor with fork capabilities | decodes; fork flags dropped | | `thread.issue-linked` and every fork-only event type | rejected | The last row is why the server must never send a fork event to an upstream client. A server case now proves that rule on resume: only upstream message events and the sync marker arrive, live and on replay. | File | Change | | --- | --- | | `scripts/upstream-client-compat.fork.test.ts` | new; upstream contracts from `git merge-base HEAD upstream/main` | | `apps/server/src/ws.threadIssues.fork.suite.ts` | resume-from-sequence case | | `.github/workflows/hyprws-ci.yml` | Test Scripts job fetches upstream history | | `docs/fork/internals/fork-development.md` | no fork mobile build; compatibility rule | | `docs/fork/user/managed-terminals.md` | drops two mobile claims | ## Why The fork ships no mobile build; users run the upstream app against a fork server. Nothing proved the linked-issue wire additions left that app working. This is part of #1430. The test reads upstream at the merge-base, today `v0.0.44`, the tag store builds come from. ## Checks ```text vp test run scripts/upstream-client-compat.fork.test.ts → exit 0 (3 tests) vp test run apps/server/src/server.test.ts → exit 0 (213 tests) tsc --noEmit (scripts, apps/server) → exit 0 vp run knip:check → exit 0 vp run fork:ci → exit 0 (60 files, 679 tests) ``` ## Evidence The compat test against the upstream `v0.0.44` contracts. ![compat-1435-terminal-compat.png](https://github.com/user-attachments/assets/20a57072-a91f-4e9d-b7a2-7d20c41f336b) ## Close conditions Refs #1435 The **Upstream app** condition stays open: it needs the upstream Android app in an emulator. | Condition | Evidence | | --- | --- | | Shell | shell and thread-detail cases | | Config | environment descriptor case | | Events | fork-only rejection case; server resume case | | Docs | fork guide Mobile rule | | Rule | fork guide compatibility table | ## Checklist - [x] This PR is small and focused - [x] I explained what changed and why - [x] I included before/after screenshots for any UI changes - [x] I included a video for animation/interaction changes No UI or motion changed. Opus 5.5 via Claude Code in T3 Code. ## Fork trailers Squashes: - 50e9c9e test(github-issues): prove the upstream app still reads a fork server (#1452) (#1452) (#1453) - e4a3774 fixup! test(github-issues): prove the upstream app still reads a fork server (#1452) (#1452) - d17fd1f test(github-issues): prove the upstream app still reads a fork server (#1452) (#1452) (#1453) - 4c172af test(github-issues): the upstream-client compat check reads V2 wire schemas - c827832 test(github-issues): the upstream-client compat check reads issue links on V2 metadata events Fork-Domain: github-issues Fork-Tier: qol Fork-Upstreamable: no
1 parent eaf2f16 commit a75bcda

3 files changed

Lines changed: 584 additions & 2 deletions

File tree

‎.github/workflows/hyprws-ci.yml‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -255,6 +255,7 @@ jobs:
255255
- name: Checkout
256256
uses: actions/checkout@v6
257257
with:
258+
fetch-depth: 0
258259
sparse-checkout: |
259260
/*
260261
!/.repos/
@@ -273,6 +274,13 @@ jobs:
273274
- name: Install browser secret helper build libraries
274275
run: sudo apt-get update && sudo apt-get install -y libsecret-1-dev pkg-config
275276

277+
# upstream-client-compat.fork.test.ts decodes fork payloads with the
278+
# contracts at `git merge-base HEAD upstream/main`.
279+
- name: Fetch upstream
280+
run: |
281+
git remote add upstream https://github.com/pingdotgg/t3code.git
282+
git fetch --no-tags upstream main
283+
276284
- name: Test
277285
run: vp run --filter @t3tools/scripts test
278286

‎docs/fork/user/managed-terminals.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ Hidden terminals stay asleep.
3131
| **Partial** | the steps that succeeded, plus **Retry** |
3232
| **Complete** | **Undo**, while the physical checkout still matches |
3333

34-
Web, desktop, and mobile show the same status and recovery action.
34+
Web and desktop show the same status and recovery action.
3535

3636
## Follow or pin a terminal
3737

@@ -42,7 +42,7 @@ Terminal views follow their thread by default.
4242
| **Pin to this checkout** | keeps this device's view where it is |
4343
| **Follow thread checkout** | reattaches to the thread's effective checkout |
4444

45-
The preference is local to that browser or mobile device.
45+
The preference is local to that browser.
4646
Pinning does not close or move other devices or external zmux clients.
4747

4848
Both controls are disabled while a move is queued or preparing.

0 commit comments

Comments
 (0)