You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit a743556
Browse filesBrowse the repository at this point in the historyBrowse files
fix(web): issues and links closed as not planned no longer show the merged or completed purple
## What Changed
Issue reads carry GitHub's close reason; a closed issue that did not land drops the merged purple.
| Layer | Change |
| --- | --- |
| Contracts | optional `closeReason` on list and detail entries |
| Server | reads `stateReason`; maps completed and not planned |
| Web | not planned and missing reason use the draft grey |
`REOPENED`, duplicate, and unknown reasons read as none, so they show grey.
Sub-issues and thread-link snapshots keep the completed tone: `gh` sends no `stateReason` on sub-issue nodes, and snapshots store none.
## Why
Every closed issue showed the merged purple, even one closed as not planned, which GitHub shows in grey.
Closes#1449
## Close conditions
- [x] **Reason:** issue reads carry the close reason
- [x] **Completed:** stays purple
- [x] **Not planned:** shows a neutral tone
- [x] **Older server:** a missing reason shows neutral
The older-server case is covered by the presentation test; an upstream client still decodes the entries.
## Checks
```text
vp test run <touched tests> → exit 0 (40 passed)
vp test run <adjacent issue tests> → exit 0 (103 passed)
vp test run upstream-client-compat → exit 0 (7 passed)
typecheck contracts, server, web → exit 0
vp run knip:check → exit 0
vp run fork:ci → exit 0
```
## Evidence
Closed issues on `/issues`: #1450 (not planned) in grey between completed issues in purple.

Full list, where #1443 (duplicate) is grey too:

## Checklist
- [x] This PR is small and focused
- [x] I explained what changed and why
- [x] I included before/after screenshots for any UI changes
- [x] I included a video for animation/interaction changes
Before, every closed glyph was purple. No motion changed.
Pi peer worker, hosted by Opus 5.5 via Claude Code in T3 Code.
## Fork trailers
Squashes:
- 8527cad fix(web): issues and links closed as not planned no longer show the merged or completed purple (#1456) (#1463)
- 373225c test(web): the issue detail draft fixture carries upstream's threadContexts
Fork-Domain: github-issues
Fork-Tier: bugfix
Fork-Upstreamable: no
0 commit comments