Repository navigation
Commit 7f24727
fix(voice-input): use InlineButton for processing error dismissal (#1800)
## Problem
The dismissible voice-processing error duplicates the shared inline action primitive.
## Change
#1792 ui-consistency-2: use destructive `InlineButton` for error dismissal, preserving its tooltip, accessible label, truncation, and dismiss handler.
Visible differences are the primitive's hover underline, destructive tone, and keyboard focus outline.
#1792 ui-consistency-1: held: mirrors upstream composer action button; no shared Button variant upstream, and adding one means a hook in a high-churn upstream file.
The finish/retry markup and `ui/button.tsx` match `origin/hyprws` exactly.
#1792 ui-consistency-3: held because moving both static rules requires separate upstream hooks in `ChatComposer` (live padding) and `ComposerSurface` (shell geometry), exceeding the approved one-hook limit.
The fork-only stylesheet remains unchanged.
## Scope and approval
Maintainer-directed, issue-free consistency fix for existing desktop dictation; no new capability, mobile changes, or backfill PR edits.
The host's Round 3 ruling prioritizes sync-conflict avoidance over adding shared button variants.
## Verification
`vp lint apps/web/src/voice-input/useVoiceText.fork.tsx` → exit 0 (0 errors, 0 warnings).
`cd apps/web && vp run typecheck` → exit 0.
`vp run fork:ci` → exit 0 (63 files, 776 tests passed; 0 lint errors, 451 warnings).
No tests were touched, so no touched-test command applies.
The previous head's cloud Test Web failed `AttachmentFilePreview.browser.test.tsx:74` (8,786 passed, 1 failed).
The host identifies AttachmentFilePreview and WorkflowOpeningBlock failures as known base flakes; do not fix or rerun them in this scope.
Host browser grounding: see Evidence.
No browser or dev server was started.
Implemented by GPT-6.1 Sol through Pi.
## Evidence
Web client, dark, 1280x800, seeded dev data: `hyprws` vs this PR merged on the current base.
The error state was set directly in React state; a real failure needs a failing provider call.
- Shows: error at rest, hovered, keyboard focus
- Rest: destructive tone at 80%, full on hover
- Hover: underline; tooltip and truncation unchanged
- Focus: shared ring outline

## Fork trailers
Fork-Domain: voice-input
Fork-Tier: qol
Fork-Upstreamable: no
Co-authored-by: donjor <[email protected]>1 parent 874ffea commit 7f24727
1 file changed
Lines changed: 6 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
302 | 302 | | |
303 | 303 | | |
304 | 304 | | |
305 | | - | |
306 | | - | |
307 | | - | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
308 | 308 | | |
309 | 309 | | |
310 | 310 | | |
311 | | - | |
312 | | - | |
| 311 | + | |
| 312 | + | |
313 | 313 | | |
314 | 314 | | |
315 | 315 | | |
| |||
0 commit comments