You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 7c7faf7
Browse filesBrowse the repository at this point in the historyBrowse files
fix(issues): persist controls, show parents, and search all issues (#1744)
## Problem
Issues list controls reset on remount, detail panels omit the parent, and filters/order only affect a capped page.
Closes#151.
Closes#152.
Closes#153.
## Change
- **Controls:** persist order and filters.
- **Parent:** show it and follow it in place.
- **Search:** filter before page selection.
- **Order:** retain client cross-project merging.
- **Footer:** describe capped results.
The existing search operation now accepts filter and sort qualifiers, using `ISSUE_ADVANCED` for native issue types.
Labels retain OR inclusion and AND exclusion; multiple types use grouped OR.
Local narrowing remains as a compatibility fallback for older servers that ignore `listViewFork`; those servers still filter only their returned page.
**Reaction limitation:** GitHub supports total or individual reaction sorts, not the client's positive/negative sums.
Both reaction controls request `sort:reactions-asc/desc`, then preserve aggregate ordering locally.
The footer only says “More issues match than are shown.”
No filter semantics were intentionally dropped.
Qualifier references: [issue filters](https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/filtering-and-searching-issues-and-pull-requests), [search qualifiers](https://docs.github.com/en/search-github/searching-on-github/searching-issues-and-pull-requests), and [sort qualifiers](https://docs.github.com/en/search-github/getting-started-with-searching-on-github/sorting-search-results).
## Scope and approval
The maintainer approved these three Issues fixes as one PR in the implementation brief, including server qualifiers and retained client merging.
Web and desktop share this surface; optional wire fields preserve older-client decoding.
No provider, server runtime, or upstream publication changes.
## Verification
- [x] **Tests:** 145 passed, 0 failed.
- [x] **Types:** web/server/contracts, exit 0.
- [x] **Build:** web production, exit 0.
- [x] **Gate:** `vp run fork:ci`, exit 0.
- [ ] **Host:** browser grounding and UI evidence.
Tests cover search query construction, an older issue selected by comment rank, parent decoding, restored local matching, and preferences restored after a remount.
The mocked parent-panel test is removed; the host owns real-browser parent display and navigation verification.
No browser or development server was started; this PR remains draft for the host's integrated verification.
Implementation: gpt-6.1-sol in Pi; host: claude-opus-5-5 in Claude Code.
## Fork trailers
Squashes:
- 7b7b88e fix(issues): persist controls, show parents, and search all issues (#1744) (#1744)
- 185c96d fixup! fix(issues): persist controls, show parents, and search all issues (#1744) (#1744)
Fork-Domain: github-issues
Fork-Tier: bugfix
Fork-Upstreamable: no
"login ... on User { name avatarUrl } ... on Organization { name avatarUrl }";
53
54
constISSUE_BASE_SELECTION=`number title url author { ${ISSUE_ACTOR_SELECTION} } assignees(first: 100) { nodes { login name avatarUrl } } labels(first: 100) { nodes { name color } } issueType { name color } state stateReason createdAt updatedAt reactionGroups { content users { totalCount } }`;
54
55
constISSUE_SUMMARY_SELECTION="title state stateReason";
55
-
constISSUE_DETAIL_SELECTION=`${ISSUE_BASE_SELECTION} body subIssues(first: 100) { nodes { number title url state stateReason } } closedAt comments(last: ${DETAIL_COMMENT_LIMIT}) { totalCount nodes { id author { ${ISSUE_ACTOR_SELECTION} } body createdAt updatedAt url } }`;
56
+
constISSUE_DETAIL_SELECTION=`${ISSUE_BASE_SELECTION} body parent { number title url state stateReason } subIssues(first: 100) { nodes { number title url state stateReason } } closedAt comments(last: ${DETAIL_COMMENT_LIMIT}) { totalCount nodes { id author { ${ISSUE_ACTOR_SELECTION} } body createdAt updatedAt url } }`;
56
57
57
-
constISSUE_SEARCH_QUERY=`query($query:String!,$first:Int!){search(query:$query,type:ISSUE,first:$first){nodes{... on Issue{${ISSUE_BASE_SELECTION} comments{totalCount}}}}}`;
58
+
constISSUE_SEARCH_QUERY=`query($query:String!,$first:Int!,$type:SearchType!){search(query:$query,type:$type,first:$first){nodes{... on Issue{${ISSUE_BASE_SELECTION} comments{totalCount}}}}}`;
0 commit comments