Repository navigation
Commit 5238881
fix(web): compose bookmark rows from shared primitives (#1798)
## Problem
Bookmark rows duplicated discovery-row and removal-button styling.
Review findings: #1795 ui-consistency-1 and ui-consistency-2.
## Change
Use DiscoveryListRow with a sibling ghost-muted icon Button, keeping navigation and removal as separate keyboard targets.
Reserve trailing space so removal does not cover the label; reveal removal on hover and focus-within.
#1795 ui-consistency-3 was already fixed in 4f4b326; no holds.
Visible differences: shared button sizing and focus treatment, more trailing label space, removal visible while either control has focus.
## Scope and approval
Host-approved, issue-free cleanup limited to browser bookmarks.
The review-only backfill PR remains untouched.
No shared primitive or upstream-owned file changes.
## Verification
- [x] Changed-file lint: exit 0
- [x] Web typecheck: exit 0
- [x] fork:ci: exit 0; 776 tests passed
- [x] Host browser grounding: see Evidence
No tests changed; no dev server or browser launched, as directed.
Host owns before/after evidence, keyboard verification, hover/focus-within reveal, and label/hit-area separation.
Model: GPT-6.1 Sol; harness: Pi.
## Evidence
Web client, dark, 1280x800, seeded dev data: `hyprws` vs all five fix branches merged.
- Shows: rest, row hover, remove-button focus
- Long label truncates before the `X`
- `X` shows on hover and keyboard focus

## Fork trailers
Fork-Domain: browser-bookmarks
Fork-Tier: qol
Fork-Upstreamable: no
Co-authored-by: donjor <[email protected]>1 parent 012cb09 commit 5238881
2 files changed
Lines changed: 22 additions & 26 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
| 6 | + | |
5 | 7 | | |
6 | 8 | | |
7 | 9 | | |
| |||
19 | 21 | | |
20 | 22 | | |
21 | 23 | | |
22 | | - | |
23 | | - | |
| 24 | + | |
24 | 25 | | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
45 | 41 | | |
46 | 42 | | |
47 | 43 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
69 | | - | |
| 69 | + | |
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
| |||
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
80 | | - | |
| 80 | + | |
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
| |||
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
89 | | - | |
| 89 | + | |
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
| |||
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
100 | | - | |
| 100 | + | |
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
| |||
0 commit comments