Repository navigation
Commit 41187c6
chore(fork-meta): teach rsi-pr-agent workflows the fork hook seam (#1839)
## Problem
`effect-service-conventions` flagged a fork-only helper on #1837 and asked to move it into upstream `BootService`.
The fork forbids that: upstream files take only `fork-hook` lines.
The rubric's only context is `docs/internals/effect-services.md`, so the reviewer never saw the fork rule.
## Change
- **Adds:** a "Fork seams" section to both workflows
- **Sanctions:** fork helpers reached from a hook
- **Forbids:** asking to move fork logic upstream
- **Points to:** `fork-delta.md` "Carry cost"
`fork-delta.md` (123 KB) exceeds the 64 KB context cap, so the rubric names it instead of loading it.
A separate rsi-pr-agent change injects each repository's root `AGENTS.md` into every review; this covers the gap meanwhile.
## Scope and approval
Requested by the maintainer in session after the false finding on #1837.
## Verification
- **Frontmatter:** unchanged; `rsi:definitions` validates
- `vp run fork:ci → exit 0`
- **Not run:** a live review against the new rubric
Claude Opus 5.5, Claude Code in T3 Code.
## Fork trailers
Fork-Domain: fork-meta
Fork-Tier: qol
Co-authored-by: donjor <[email protected]>1 parent 94bb436 commit 41187c6
2 files changed
Lines changed: 24 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
0 commit comments