Skip to content

Commit 41187c6

Browse files
donjor-agent[bot]donjor
authored andcommitted
chore(fork-meta): teach rsi-pr-agent workflows the fork hook seam (#1839)
## Problem `effect-service-conventions` flagged a fork-only helper on #1837 and asked to move it into upstream `BootService`. The fork forbids that: upstream files take only `fork-hook` lines. The rubric's only context is `docs/internals/effect-services.md`, so the reviewer never saw the fork rule. ## Change - **Adds:** a "Fork seams" section to both workflows - **Sanctions:** fork helpers reached from a hook - **Forbids:** asking to move fork logic upstream - **Points to:** `fork-delta.md` "Carry cost" `fork-delta.md` (123 KB) exceeds the 64 KB context cap, so the rubric names it instead of loading it. A separate rsi-pr-agent change injects each repository's root `AGENTS.md` into every review; this covers the gap meanwhile. ## Scope and approval Requested by the maintainer in session after the false finding on #1837. ## Verification - **Frontmatter:** unchanged; `rsi:definitions` validates - `vp run fork:ci → exit 0` - **Not run:** a live review against the new rubric Claude Opus 5.5, Claude Code in T3 Code. ## Fork trailers Fork-Domain: fork-meta Fork-Tier: qol Co-authored-by: donjor <[email protected]>
1 parent 94bb436 commit 41187c6

2 files changed

Lines changed: 24 additions & 0 deletions

File tree

‎.rsi-agent/workflows/effect-service-conventions.md‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,3 +65,15 @@ Review changed TypeScript under `apps/`, `packages/`, and `infra/`, tests aside,
6565
## Reporting
6666

6767
Report only violations introduced by changed lines. Name the smallest relevant range for each and state the expected fix. Optional style preferences and untouched legacy code are not findings.
68+
69+
## Fork seams
70+
71+
This repository is a fork that rebases onto upstream often; `docs/fork/internals/fork-delta.md` "Carry cost" owns the rule.
72+
73+
- **Fork code:** `*.fork.ts(x)` or fork-only files
74+
- **Upstream files:** only marked `fork-hook` lines
75+
- **Sanctioned:** a fork helper reached from a hook
76+
- **Never ask:** to move fork logic upstream
77+
- **Never ask:** to edit upstream lines
78+
79+
A convention above that would need either is not a finding; report it against the fork file instead, if at all.

‎.rsi-agent/workflows/ui-consistency.md‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,3 +49,15 @@ Hold new and changed UI to that shape:
4949
## Reporting
5050

5151
Report only violations introduced by changed lines. Keep each brief: name the rule, name the primitive or location the code should use instead, and stop. Do not comment on class ordering, aesthetic preference, or untouched legacy code, and do not demand cleanup outside the PR's scope.
52+
53+
## Fork seams
54+
55+
This repository is a fork that rebases onto upstream often; `docs/fork/internals/fork-delta.md` "Carry cost" owns the rule.
56+
57+
- **Fork code:** `*.fork.ts(x)` or fork-only files
58+
- **Upstream files:** only marked `fork-hook` lines
59+
- **Sanctioned:** a fork helper reached from a hook
60+
- **Never ask:** to move fork logic upstream
61+
- **Never ask:** to edit upstream lines
62+
63+
A convention above that would need either is not a finding; report it against the fork file instead, if at all.

0 commit comments

Comments
 (0)