Skip to content

Commit 3f3567c

Browse files
donjor-agent[bot]donjor
authored andcommitted
fix(ci): release CLI executable builds on the engines.node pin (#1834)
## Problem Every `hyprws Release` since the `a4050c5` sync fails at **Build CLI single-executable**: ```text error: Native CLI executables must be built with Node 26.12.1; running 26.8.2. ``` Upstream now pins `engines.node` and requires that exact version; the fork mirror still forced `VP_NODE_VERSION: "26.8.2"`. ## Change Drop the `VP_NODE_VERSION` override, as upstream did. Setup Vite+ already selects the `engines.node` version from `package.json`. ## Scope and approval Trunk release breakage found while fixing that sync's snags. ## Verification - `vp run fork:ci` → exit 0 - Not run: a Release build; the next Release run proves it Claude Opus 5.5, Claude Code in T3 Code. ## Fork trailers Fork-Domain: fork-meta Fork-Tier: bugfix Fork-Upstreamable: no Co-authored-by: donjor <[email protected]>
1 parent 2cb66a3 commit 3f3567c

1 file changed

Lines changed: 2 additions & 6 deletions

File tree

‎.github/workflows/hyprws-release.yml‎

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -572,14 +572,10 @@ jobs:
572572
# The self-contained CLI archive every runtime installer downloads.
573573
# Mirrors the cli_archive steps of upstream release-desktop.yml for
574574
# linux-x64; mirror them again on every rebase. The fork publishes no npm
575-
# packages, so upstream publish_cli has no counterpart here.
575+
# packages, so upstream publish_cli has no counterpart here. Setup Vite+
576+
# selects the exact engines.node version the executable embeds.
576577
- name: Build CLI single-executable
577578
shell: bash
578-
env:
579-
# The exact version, not a major: vp downloads it from nodejs.org/dist on
580-
# the runner, and only exact versions have a dist directory. Keep in
581-
# step with SEA_NODE_VERSION in apps/server/vite.config.ts.
582-
VP_NODE_VERSION: "26.8.2"
583579
run: node apps/server/scripts/cli.ts build-exe --verbose
584580

585581
# The desktop artifact build above compiled the resource monitor for this target.

0 commit comments

Comments
 (0)