Repository navigation
Commit 35d7d7e
feat(web): simplify the window project chooser (#1669)
## Problem
The project chooser's separate mode controls did not fit the app's native project list.
## Change
Restores the icon-bearing **All projects** row and places the standard **Exclude** Switch at its right edge, keeping the current popup width.
All projects resets picks and exclusion; the Switch retains picks while changing their meaning; clearing included picks shows **No projects**.
Explicit No projects also publishes an empty desktop project scope.
Stacked above #1663.
The maintainer approved this design after VMON-3 review.
Shared web/desktop chooser and client filter helpers; mobile UI, providers, and wire contracts are unchanged.
**Preserved defect:** excluding every project still makes the new-thread picker list all excluded projects.
This parent defect remains at the maintainer's request.
## Verification
Head: `69eb05f7ba6205a4dae4ea903374e855365255ef`.
Parent: `486b691b3eebbfe4b17960c9a9d6cdebcbef1a20`.
| Check | Result |
| --- | --- |
| Chooser and window-scope tests | Exit 0, 24 tests |
| Web typecheck and production build | Exit 0 each |
| `vp run fork:ci` on this head | Exit 0 |
| React Doctor, changed files | Exit 0, no findings; score 66/100 |
| Real Chrome on VMON-3 | Desktop, 375px, pointer, Tab/Space, Home/Enter reset |
| Search, modes, counts, All/None | Pass; None survives reload |
| All-six-excluded picker | Known failure reproduced and preserved |
| Required GitHub checks at 69eb05f | All eight passed |
Native Electron, native mobile, and remote/relay/tunnel connections were not exercised.
T3 preview was unavailable because of host AppArmor; Hypr verification was explicitly authorized.
<details>
<summary>Aftercare findings and limits</summary>
The automated report is still marked reviewing older head `6b3d782`; its last completed findings refer to `c6a7e81`.
No automated review of this head is claimed.
| Item | Current source/evidence |
| --- | --- |
| A1: None reported as all projects | Fixed in `windowProjects.fork.ts`, with empty inclusion/publication regressions |
| A2: unequal segmented controls | Superseded by the native Switch design; narrow layout inspected |
| A3: all-excluded picker fallback | Intentionally preserved; reproduced with all six fixtures |
Parent aftercare also remains in progress on `486b691`; all eight parent required checks passed.
No aftercare job, bot-owned report, or other owner's session was modified.
</details>
<details>
<summary>Before and after</summary>
| Original parent chooser at 705e594 | Approved chooser at 69eb05f |
| --- | --- |
|  |  |
</details>
<details>
<summary>Current-head Hypr recording and receipts</summary>
Open the chooser, search gh, pick gh-bot and zmux, see **Projects: 2 selected**, exclude both, see **Projects: All except 2**, switch back, and reset All projects.
The clean checkout at the full head above served the actual changed chooser from isolated worktree state on port 5936.
https://github.com/user-attachments/assets/0c52e249-b643-4798-9829-7c1fd61ea41f
Hypr take `rec-e04f.e1`, window `18000197`, VMON-3, workspace 103.
H.264, 380x480, 11.2 seconds, 30fps, no audio or speed changes.
Retained raw 9.8-21.0 seconds; removed opening 0-9.8 and trailing 21.0-21.07 idle; no internal cuts; crop `380:480:0:86`.
Browser-only masking hides thread content and main; the chooser and its native count tooltips are unchanged.
Project names and icons remain visible.
The published attachment was downloaded through `ghb attachment get`, matched byte-for-byte, and played in Chrome to `ended=true`, time/duration 11.2, error null.
SHA-256: `a98f972b9d82c9dc7fa5d65f573c2df5a8b2bd0a7879793c7bc7fa766f8ee68b`.
GitHub's embedded player is unverified; no accepted peer or grounder handoff is claimed.
The CLI returned page `pg-29`, rather than a lease UUID; no strict accept-envelope validation is claimed.
Actual tool-result receipts:
| Result | Observed operation |
| --- | --- |
| `102f5a`, exit 0 | Read hypr, chrome-debug, frontend-design, ui, zmux SKILL.md contents |
| `546914`, exit 0 | Read gh-bot, gh-post, writing-md SKILL.md contents |
| `076658`, exit 0 | Read evidence upload/readback guide and gh-post style |
| `cf683b`, exit 0 | Read gh-bot, gh-tracking, gh-post before publication |
| `7c6c78` / `6870b2`, exit 0 | Hypr capture start/stop |
| `2c19fb`, exit 0 | Trim/crop final recording and hash |
| `b7b1bf`, exit 0 | Upload current-head screenshot and recording |
| `54949f`, exit 0 | Download and byte comparison of published recording |
These are actual read/result receipts, rather than skill loading inferred from screenshots.
Body publication uses the active Codex harness directly because managed-terminal publishing previously lacked caller provenance; no identity bypass is used.
</details>
Model: GPT-6.1-Sol. Harness: Codex.
## Fork trailers
Squashes:
- e16eaa2 feat(web): simplify the window project chooser (#1669) (#1669)
- 3af673d fixup! feat(web): simplify the window project chooser (#1669) (#1669)
- e2e24ff feat(web): simplify the window project chooser (#1669) (#1669)
- 96f2eb5 fixup! feat(web): simplify the window project chooser (#1669) (#1669)
Fork-Domain: workspaces
Fork-Tier: qol
Fork-Upstreamable: no1 parent 5d52d3b commit 35d7d7e
19 files changed
Lines changed: 346 additions & 136 deletions
File tree
- apps/web/src
- components
- sidebar
- docs/user
- packages/client-runtime/src/state
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
105 | 105 | | |
106 | 106 | | |
107 | 107 | | |
| 108 | + | |
| 109 | + | |
108 | 110 | | |
109 | 111 | | |
110 | 112 | | |
| |||
147 | 149 | | |
148 | 150 | | |
149 | 151 | | |
150 | | - | |
151 | | - | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
152 | 158 | | |
153 | 159 | | |
154 | 160 | | |
| |||
184 | 190 | | |
185 | 191 | | |
186 | 192 | | |
187 | | - | |
188 | | - | |
189 | | - | |
190 | | - | |
191 | | - | |
192 | | - | |
193 | | - | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
194 | 236 | | |
195 | 237 | | |
196 | 238 | | |
197 | | - | |
198 | | - | |
199 | | - | |
| 239 | + | |
| 240 | + | |
200 | 241 | | |
201 | 242 | | |
202 | 243 | | |
203 | | - | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
204 | 249 | | |
205 | 250 | | |
206 | 251 | | |
207 | | - | |
| 252 | + | |
208 | 253 | | |
209 | 254 | | |
210 | 255 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
6 | 7 | | |
7 | 8 | | |
8 | 9 | | |
| 10 | + | |
9 | 11 | | |
10 | 12 | | |
11 | 13 | | |
12 | 14 | | |
| 15 | + | |
| 16 | + | |
13 | 17 | | |
14 | 18 | | |
15 | 19 | | |
| |||
69 | 73 | | |
70 | 74 | | |
71 | 75 | | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
72 | 126 | | |
73 | 127 | | |
74 | 128 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
452 | 452 | | |
453 | 453 | | |
454 | 454 | | |
| 455 | + | |
455 | 456 | | |
456 | 457 | | |
457 | 458 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
58 | | - | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
59 | 60 | | |
60 | 61 | | |
61 | 62 | | |
| |||
530 | 531 | | |
531 | 532 | | |
532 | 533 | | |
533 | | - | |
| 534 | + | |
534 | 535 | | |
535 | 536 | | |
536 | 537 | | |
| 538 | + | |
537 | 539 | | |
538 | 540 | | |
539 | 541 | | |
| |||
825 | 827 | | |
826 | 828 | | |
827 | 829 | | |
828 | | - | |
829 | | - | |
| 830 | + | |
| 831 | + | |
830 | 832 | | |
831 | 833 | | |
832 | 834 | | |
| |||
1648 | 1650 | | |
1649 | 1651 | | |
1650 | 1652 | | |
1651 | | - | |
| 1653 | + | |
1652 | 1654 | | |
1653 | 1655 | | |
1654 | 1656 | | |
1655 | 1657 | | |
1656 | 1658 | | |
| 1659 | + | |
1657 | 1660 | | |
1658 | 1661 | | |
1659 | 1662 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | 2 | | |
4 | 3 | | |
5 | 4 | | |
| |||
97 | 96 | | |
98 | 97 | | |
99 | 98 | | |
100 | | - | |
101 | 99 | | |
102 | 100 | | |
103 | 101 | | |
| |||
112 | 110 | | |
113 | 111 | | |
114 | 112 | | |
115 | | - | |
| 113 | + | |
116 | 114 | | |
117 | 115 | | |
118 | 116 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3012 | 3012 | | |
3013 | 3013 | | |
3014 | 3014 | | |
3015 | | - | |
3016 | | - | |
3017 | | - | |
3018 | | - | |
3019 | | - | |
3020 | | - | |
3021 | 3015 | | |
3022 | 3016 | | |
3023 | 3017 | | |
| |||
3071 | 3065 | | |
3072 | 3066 | | |
3073 | 3067 | | |
| 3068 | + | |
| 3069 | + | |
| 3070 | + | |
| 3071 | + | |
| 3072 | + | |
| 3073 | + | |
| 3074 | + | |
| 3075 | + | |
3074 | 3076 | | |
3075 | 3077 | | |
3076 | 3078 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
| 13 | + | |
12 | 14 | | |
13 | 15 | | |
14 | 16 | | |
15 | 17 | | |
16 | 18 | | |
17 | 19 | | |
18 | 20 | | |
| 21 | + | |
19 | 22 | | |
20 | | - | |
| 23 | + | |
21 | 24 | | |
22 | 25 | | |
23 | 26 | | |
| |||
89 | 92 | | |
90 | 93 | | |
91 | 94 | | |
92 | | - | |
| 95 | + | |
93 | 96 | | |
94 | 97 | | |
95 | 98 | | |
96 | 99 | | |
97 | 100 | | |
98 | 101 | | |
99 | 102 | | |
100 | | - | |
| 103 | + | |
101 | 104 | | |
102 | | - | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
120 | 120 | | |
121 | 121 | | |
122 | 122 | | |
| |||
0 commit comments