You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 2299d18
Browse filesBrowse the repository at this point in the historyBrowse files
authored and
rsi-pr-agent
committed
chore(fork): fork tooling sheds its dead flags, outputs, and stale docs (#1504)
## Problem
The fork tooling carried flags, workflow outputs, header comments, and docs that nothing reads or that no longer match the scripts.
`fork-delta.md` also named guards that do not exist: `fork-hook-seam`, `ADOPTED_AUTHORING_GUARDS`, `unexplainedRemoval`.
## Change
Deletions and simplifications only; no new behavior.
| Surface | Change |
| --- | --- |
| Script headers | Gate and job-step comments gone, with their two pinning tests |
| `fork:delta` | `--squash-body` needs no refs; unused `warnings` gone; table separator fixed |
| `fork:release-gate` | `--github-output` gone |
| `fork-ci-flags` | Emits only `since`, the one output CI reads |
| `fork:sync` | Battery drops its duplicate `fork:delta --check`; `publishedVia` drops `ghb` |
| `fork:scan` | Help and comments lose step numbering |
| `package.json` | `fork:release-version` and `fork:release-delta-rev` aliases gone |
| `hyprws-body.yml` | No full fetch, no ref env |
| `hyprws-release.yml` | Unread `gate_reason` output and preflight Electron install gone |
| `hyprws-upstream-sync.yml` | Unread `exit` output gone |
| `fork-delta.md` | Nonexistent guards and dead subsections gone; scan targets and roles match |
| `fork-sync.md` | Battery and required contexts match the ruleset |
| `fork-development.md` | Body workflow marked advisory |
| PR template | Points to `FORK_DOMAINS` instead of copying it |
| Kept | Why |
| --- | --- |
| `fork:regenerate-route-tree` | Still used by the sync |
| "Marking a hook" | Only doc of the live `fork-hook:` marker |
| Release "Fork ledger" step | No release job repeats it |
## Scope and approval
Closes#1410
- [ ] **Docs:** every row above matches the scripts
- [ ] **Code:** every row above deleted or simplified
- [ ] **Checks:** `vp run fork:ci` passes
## Verification
| Command | Exit |
| --- | --- |
| `vp run fork:ci` | 0 |
| `vp run fork:delta --check` | 0 |
| `vp run knip:check` | 0 |
| `vp run --filter @t3tools/scripts typecheck` | 0 |
| `vp test run` on the six touched fork test files (110 tests) | 0 |
Claude Opus 5.5 in Claude Code, hosted by T3 Code.
## Fork trailers
Squashes:
- fbd91f5 chore(fork): fork tooling sheds its dead flags, outputs, and stale docs (#1504) (#1504)
- ade60af fixup! chore(fork): fork tooling sheds its dead flags, outputs, and stale docs (#1504) (#1504)
Fork-Domain: fork-meta
Fork-Tier: qol
Co-authored-by: donjor <[email protected]>
| Fork CI | Blocking, every push | its upstream merge base |
33
+
| The sync driver's check step (`hyprws-upstream-sync.yml`) | Blocking | the target tag |
37
34
38
35
## Why the fork exists
39
36
@@ -71,14 +68,13 @@ A retirement is recorded by the retire commit itself, not a ledger.
71
68
`Fork-Repair` marks a repair the next fold absorbs.
72
69
`vp run fork:delta --check` enforces the table on every push, and a rebase preserves trailers.
73
70
74
-
**Squash-body mode.**Fork CI also runs it with`--base origin/hyprws --head <sha> --squash-body <file>`, both refs explicit.
71
+
**Squash-body mode.**The advisory `hyprws Body` workflow runs`--check --squash-body <file>`; it is not a required check.
75
72
It validates the body's final trailer paragraph, which becomes the squash trailers.
76
73
A trailer carried only by a branch commit cannot satisfy it.
77
74
78
75
## Carry cost
79
76
80
77
Decided per commit by the levers retire, reshape, automate, or accept; no gate carries a numeric cap.
81
-
82
78
**Accept is never "as-is".** A kept commit needs a mechanical seam: fork code in fork-only files, and upstream files carrying only marked hook lines the walk re-applies.
83
79
84
80
### Marking a hook
@@ -87,7 +83,6 @@ Decided per commit by the levers retire, reshape, automate, or accept; no gate c
| Multi-line JSX | the pair `{/* fork-hook: <domain>/<name> */}` and `{/* fork-hook-end */}`|
90
-
| Charging |`scripts/lib/fork-hooks.ts` is fork-owned, so its edit is never charged |
91
86
92
87
**A hook is exactly one construct:** one import, one call, one `const` from a single fork call, one JSX element, one fork-named property or spread, or one re-export.
93
88
**A hook never removes or modifies an upstream line**, except that a marked JSX region may re-indent what it wraps, and an in-place substitution removes the line its marked replacement supplies.
| Fork side | rebuilt from the upstream blob and the diff's positions |
153
-
| Unreconstructable | charged, never exempted |
154
-
| Removal gap | every addition in it must be a line-kind marked hook |
155
-
| Formatter reflow | same tokens either side: no `fork-hook-seam` addition charge; the hook guard has no such exemption |
156
-
| Outside the rule | upstreamable `bugfix` commits, and generated paths |
157
-
| Generated files | never reshape debt; a sync restores HEAD and regenerates |
158
-
| Historical range | advisory, so the woven trunk is unaffected |
159
-
160
-
It charges some seams the walk accepts, never the reverse.
161
-
A scar rule directs the author to a fork-owned file, and the narrow call left behind still needs its own marker.
162
-
163
-
### Declaration and placement
164
-
165
-
**Declaration comes from the fork tip, placement from the replayed blob, and the tip wins**, because a seam whose owning commit predates its marker carries no marker in that blob.
|`Fork-Repair` commits | visible per commit, excluded from domain sums |
181
-
|`vp run fork:delta --inventory`| measures the checkout; the sync report measures nothing |
182
-
183
-
**A `.fork.` in a filename is a reader signal only.**
184
-
No guard decides on it, and its one placement rule is [Fork tests live in fork-owned files](./fork-development.md#fork-tests-live-in-fork-owned-files).
185
-
A per-file diff says nothing about seam growth until `git cat-file -e origin/main:<path>` proves the path exists upstream.
186
-
187
128
## Domain index
188
129
189
130
| Domain | Status | Tiers present | Retires when |
@@ -445,10 +386,10 @@ Upstream ships rich Markdown editing with safe frontmatter and MDX boundaries, o
Copy file name to clipboardExpand all lines: docs/fork/internals/fork-development.md
+2-2Lines changed: 2 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -130,7 +130,7 @@ Land onto `hyprws` by squash; a merge commit breaks the stack.
130
130
-**Never raw `git merge`:** bypasses both
131
131
132
132
`ghb pr merge` squashes with the PR title and body, so end it with trailers.
133
-
`.github/workflows/hyprws-ci.yml` is the required check.
133
+
`.github/workflows/hyprws-ci.yml` is the required check; `hyprws-body.yml` checks the body's trailers and citations, advisory only.
134
134
Non-linear movement onto `hyprws` voids a sync run's lease; the next run rebases over a merge commit the same way over any other base, which is exactly what the fork stack forbids.
135
135
136
136
## Upstream citations
@@ -215,7 +215,7 @@ forkSupersedes({
215
215
The import is a typed no-op: `fork:scan` reads the declaration from the sibling's text and never runs it.
216
216
Never `it.skip`, a comment-out, or an in-place edit: a bare skip loses an assertion unnoticed.
0 commit comments