Skip to content

Commit 14b6cd1

Browse files
donjor-agent[bot]donjor
authored andcommitted
fix(web): retire the fork's durable sidebar Done and run age (#1608)
## Problem The fork kept the sidebar Done after a thread was read, plus a run age. With a background command still running, a read thread read **Done now** beside `Running: … · Stop` (#1604). ## Change Retire fork commit `9e5f6e0442b`; Done is upstream's unread-only label again. - **Dropped:** `Sidebar.completedTiming.fork.ts` - **Dropped:** `SidebarCompletedTiming.fork.tsx` - **Restored:** upstream lines in `Sidebar.tsx` - **Tests:** fork cases and export hook removed The row and hover-card run duration go with it. Closes #1605 ## Scope and approval Owner-directed retirement under #1604, after an upstream comparison. The unread Done while a command runs is upstream design; #1606 watches its fix. ## Verification Dev server, Claude Sonnet 5.5, read thread, background `sleep 150`: | Before | After | | --- | --- | | ![before](https://github.com/user-attachments/assets/6cc28938-1684-40a6-8c79-354e2e170d15) | ![after](https://github.com/user-attachments/assets/53244c89-3fe4-499b-a263-db006514c2d1) | Row strip: Working, Working, then only "now". ![strip](https://github.com/user-attachments/assets/0429fdfe-a292-442b-8748-2e8def1583ab) https://github.com/user-attachments/assets/6f793e11-50c4-44b3-9ce1-e2a3ef990fe7 | Check | Result | | --- | --- | | `vp test run` sidebar logic tests | exit 0, 150 passed | | `vp run typecheck` in `apps/web` | exit 0 | | `vp run fork:delta --check` | exit 0 | | `vp run fork:ci` | exit 0 | ## Close conditions - [x] **Grounded:** read thread, live command, no pill - [x] **Delta:** `vp run fork:delta --check` passes - [x] **CI:** `vp run fork:ci` passes Made with Claude Code (Claude Opus 5.5). ## Fork trailers Fork-Domain: upstream-fixes Fork-Tier: bugfix Fork-Upstreamable: no Co-authored-by: donjor <[email protected]>
1 parent bb85595 commit 14b6cd1

3 files changed

Lines changed: 0 additions & 106 deletions

File tree

‎apps/web/src/components/Sidebar.completedTiming.fork.ts‎

Lines changed: 0 additions & 63 deletions
This file was deleted.

‎apps/web/src/components/Sidebar.logic.test.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,6 @@ function makeLatestRun(overrides?: {
223223
overrides?.completedAt !== undefined ? overrides.completedAt : "2026-03-09T10:05:00.000Z",
224224
};
225225
}
226-
export { makeLatestRun }; // fork-hook: upstream-fixes/sidebar-latest-run-export
227226

228227
describe("orderItemsByPreferredIds", () => {
229228
it("resolves legacy preference aliases without materializing project state", () => {

‎apps/web/src/components/SidebarCompletedTiming.fork.tsx‎

Lines changed: 0 additions & 42 deletions
This file was deleted.

0 commit comments

Comments
 (0)