Repository navigation
Commit 10ce76a
fix(desktop): ignore installed dependencies in pack watchers (#1767)
## Problem
pnpm hardlink metadata changes can rebuild desktop bundles and relaunch Electron without a source edit.
## Change
Wrap the pack array once to apply the existing watch exclusion to every desktop bundle:
```ts
ignoreWatch: /[\\/]node_modules[\\/]/
```
Workspace imports resolve through their symlinks to source paths outside `node_modules`, so they remain watchable.
One bounded fixture build checks that installed dependencies are excluded while linked `contracts` and `shared` sources remain watchable.
## Scope and approval
Refs #1614.
This PR covers only the Watch condition; the historical 14:10:20 hardlink-source condition stays open.
The host approved this scope and owns runtime grounding; no watcher or Electron instance was started by the worker.
## Verification
- [x] Focused bundle tests: 3 passed
- [x] Targeted lint and desktop typecheck
- [x] Desktop production pack
- [x] `vp run fork:ci`: 762 tests passed
- [x] Host-owned Electron runtime grounding: below
The regression test checks actual bundler-resolved paths against the configured filter, not runtime filesystem events.
## Grounding
**Claim:** under `vp run dev:app --desktop`, dependency changes keep Electron running; source edits relaunch it.
- **Build:** PR head `f227ae6fed`
- **Client:** Electron dev app, checkout-local state
- **Dependency:** bundled `effect` `Pipeable.js`
| Step | Windows created | Electron |
| --- | --- | --- |
| launch | 1 | running |
| dependency `chmod` and `touch` | 1 | same PID |
| dependency hardlink (links 14 → 15) | 1 | same PID |
| touch `apps/desktop/src/main.ts` | 2 | relaunched |
| touch `packages/contracts/src/background.ts` | 3 | relaunched |
| touch `packages/shared/src/schemaJson.ts` | 4 | relaunched |
**Not grounded:** the pre-fix relaunch; no baseline run.
Model: GPT Sol (`gpt-6.1-sol`). Harness: Pi.
## Fork trailers
Squashes:
- d27acaf fix(desktop): ignore installed dependencies in pack watchers (#1767) (#1767)
- fcd9ce3 fixup! fix(desktop): ignore installed dependencies in pack watchers (#1767) (#1767)
Fork-Domain: upstream-fixes
Fork-Tier: bugfix
Fork-Upstreamable: yes
Co-authored-by: donjor <[email protected]>1 parent 3bb83d3 commit 10ce76a
3 files changed
Lines changed: 79 additions & 2 deletions
File tree
- apps/desktop
- scripts
- scripts/lib
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
6 | 7 | | |
7 | 8 | | |
8 | 9 | | |
| |||
48 | 49 | | |
49 | 50 | | |
50 | 51 | | |
51 | | - | |
| 52 | + | |
| 53 | + | |
52 | 54 | | |
53 | 55 | | |
54 | 56 | | |
| |||
140 | 142 | | |
141 | 143 | | |
142 | 144 | | |
143 | | - | |
| 145 | + | |
144 | 146 | | |
145 | 147 | | |
146 | 148 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
0 commit comments