Repository navigation
fix(rocblas): accept --offload-jobs in rmake's compiler-jobs parser - #15166
Conversation
get_compiler_jobs only looked for parallel-jobs=, so an environment using LLVM's renamed --offload-jobs= flag was parsed as one job.
⏳ Waiting on Required Checks⏳ Required checks have not all concluded yet. This bot run is exiting without failing so those checks can report independently.
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
assistant-librarian
Bot
added
the
external contribution
|
⏳ Waiting for required checks to start or finish:
|
TorreZuk
left a comment
TorreZuk
left a comment
There was a problem hiding this comment.
Yes but the TODO to re-enable the helper is low priority as rmake is only for developer custom builds now. Still fine to fix env query
|
Thanks @TorreZuk. Agreed — re-enabling The PR has both approvals, but the required workflows (Component CI, Multi-Arch CI, pre-commit) are still waiting for approval on this fork PR, so the merge stays blocked. Could they be kicked off when you have a moment? |
fix(rocblas): accept --offload-jobs in rmake's compiler-jobs
parser (#15166)
## Summary
`rmake.get_compiler_jobs` only looked for `parallel-jobs=`, so an
environment using LLVM's renamed `--offload-jobs=4` was parsed as one
compiler job:
```python
get_compiler_jobs("--offload-jobs=4") # 1, expected 4
```
Try `--offload-jobs=` first and fall back to `parallel-jobs=` for older
toolchains, stopping at the first match.
The helper currently sits behind a disabled path
(`get_env_compiler_parallelism()` returns early), but it is the parser
for the `HIP_CLANG_NUM_PARALLEL_JOBS` / `CCC_OVERRIDE_OPTIONS` path and
the rename makes it wrong by construction once that path is re-enabled.
## Testing
Python 3.12.3:
```python
import rmake
[rmake.get_compiler_jobs(x) for x in ("--offload-jobs=4", "-parallel-jobs=3", "none")]
```
- before: `[1, 3, 1]`
- after: `[4, 3, 1]`
Fixes #15163
TheRock Submodule Bump ActivityNewest first
|
Summary
rmake.get_compiler_jobsonly looked forparallel-jobs=, so an environment using LLVM's renamed--offload-jobs=4was parsed as one compiler job:Try
--offload-jobs=first and fall back toparallel-jobs=for older toolchains, stopping at the first match.The helper currently sits behind a disabled path (
get_env_compiler_parallelism()returns early), but it is the parser for theHIP_CLANG_NUM_PARALLEL_JOBS/CCC_OVERRIDE_OPTIONSpath and the rename makes it wrong by construction once that path is re-enabled.Testing
Python 3.12.3:
[1, 3, 1][4, 3, 1]Fixes #15163