GridwiseGemmParams: fix compile error with LLVM libc++ due to missing const#1708
Merged
umangyadav merged 1 commit intoROCm:developfrom Jan 13, 2025
Conversation
Merged
34 tasks
LunNova
changed the title
… const LLVM's C++ stdlib is more picky and requires this to be marked const to avoid compile errors when sorting.
LunNova
force-pushed
the
lunnova/fix-compile-error-with-llvm-libstdc++
branch
from
51e5585 to
5849448
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1708 +/- ##
===========================================
- Coverage 78.88% 78.57% -0.32%
===========================================
Files 100 100
Lines 28346 28346
Branches 4130 4130
===========================================
- Hits 22361 22272 -89
- Misses 4368 4415 +47
- Partials 1617 1659 +42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
umangyadav
approved these changes
Dec 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLVM's C++ stdlib is more picky and requires this to be marked const to avoid compile errors when sorting.