net_ib: fix out of bounds read in ncclIbGdrSupport on non-RDMA kernel#1470
Merged
wenkaidu merged 1 commit intoROCm:developfrom Jan 8, 2025
Merged
Conversation
LunNova
requested review from
AtlantaPepsi,
KawtharShafie,
PedramAlizadeh,
akolliasAMD,
corey-derochie-amd,
edgargabriel,
gilbertlee-amd,
haripriyaayyalasomayajula,
mberenjk,
mustafabar,
nileshnegi,
nusislam,
thananon and
wenkaidu
as code owners
Merged
34 tasks
wenkaidu
approved these changes
Jan 3, 2025
Contributor
|
CI failure on 4gfx908 was in docker stage. Thus merging the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1469
Details
Do not mention proprietary info or link to internal work items in this PR.
Work item: #1469
What were the changes?
Fixed out of bounds read and subsequent crash if none of the entries in memory_peers_path exist.
Why were the changes made?
Crashing is bad.
How was the outcome achieved?
Only crashes/demonstrates UB on a system that is missing all entries in this list.
Additional Documentation:
What else should the reviewer know?
Approval Checklist
Do not approve until these items are satisfied.