Skip to content

[AUTOGENERATED] [release/2.7] Add 3D batchnorm tests #2243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jithunnair-amd merged 1 commit into from
Jun 4, 2025
Merged

[AUTOGENERATED] [release/2.7] Add 3D batchnorm tests #2243

jithunnair-amd merged 1 commit into from
Jun 4, 2025

Conversation

@okakarpa
Copy link
Collaborator

@okakarpa okakarpa commented Jun 4, 2025

Cherry-pick of #2214

@dnikolaev-amd @jeffdaily
[release/2.6] Add 3D batchnorm tests (#2214)
ad66b89 
Additive on top of #2209

3D batchhorm tests (NHWC3D and NCHW3D)

NCHW 3D tests:

```
  test_batchnorm_3D_inference_NCHW_vs_cpu_float32 (__main__.TestNN) ... ok (0.149s)
  test_batchnorm_3D_inference_NCHW_vs_cpu_mixed_bfloat16 (__main__.TestNN) ... ok (0.062s)
  test_batchnorm_3D_inference_NCHW_vs_cpu_mixed_float16 (__main__.TestNN) ... ok (0.042s)
  test_batchnorm_3D_inference_NCHW_vs_native_float32 (__main__.TestNN) ... ok (0.091s)
  test_batchnorm_3D_inference_NCHW_vs_native_mixed_bfloat16 (__main__.TestNN) ... ok (0.008s)
  test_batchnorm_3D_inference_NCHW_vs_native_mixed_float16 (__main__.TestNN) ... ok (0.007s)
  test_batchnorm_3D_inference_NHWC_vs_NCHW_float32 (__main__.TestNN) ... ok (0.028s)
  test_batchnorm_3D_inference_NHWC_vs_NCHW_mixed_bfloat16 (__main__.TestNN) ... ok (0.010s)
  test_batchnorm_3D_inference_NHWC_vs_NCHW_mixed_float16 (__main__.TestNN) ... ok (0.010s)
  test_batchnorm_3D_inference_NHWC_vs_cpu_float32 (__main__.TestNN) ... ok (0.091s)
  test_batchnorm_3D_inference_NHWC_vs_cpu_mixed_bfloat16 (__main__.TestNN) ... ok (0.020s)
  test_batchnorm_3D_inference_NHWC_vs_cpu_mixed_float16 (__main__.TestNN) ... ok (0.023s)
  test_batchnorm_3D_inference_NHWC_vs_native_float32 (__main__.TestNN) ... ok (0.010s)
  test_batchnorm_3D_inference_NHWC_vs_native_mixed_bfloat16 (__main__.TestNN) ... ok (0.015s)
  test_batchnorm_3D_inference_NHWC_vs_native_mixed_float16 (__main__.TestNN) ... ok (0.007s)
  test_batchnorm_3D_train_NCHW_vs_cpu_float32 (__main__.TestNN) ... ok (0.011s)
  test_batchnorm_3D_train_NCHW_vs_cpu_mixed_bfloat16 (__main__.TestNN) ... ok (0.006s)
  test_batchnorm_3D_train_NCHW_vs_cpu_mixed_float16 (__main__.TestNN) ... ok (0.006s)
  test_batchnorm_3D_train_NCHW_vs_native_float32 (__main__.TestNN) ... ok (0.004s)
  test_batchnorm_3D_train_NCHW_vs_native_mixed_bfloat16 (__main__.TestNN) ... skip: bfloat16 NCHW train failed due to native tolerance issue SWDEV-507600 (0.002s)
  test_batchnorm_3D_train_NCHW_vs_native_mixed_float16 (__main__.TestNN) ... ok (0.004s)
  test_batchnorm_3D_train_NHWC_vs_NCHW_float32 (__main__.TestNN) ... ok (0.006s)
  test_batchnorm_3D_train_NHWC_vs_NCHW_mixed_bfloat16 (__main__.TestNN) ... ok (0.006s)
  test_batchnorm_3D_train_NHWC_vs_NCHW_mixed_float16 (__main__.TestNN) ... ok (0.006s)
  test_batchnorm_3D_train_NHWC_vs_cpu_float32 (__main__.TestNN) ... ok (0.004s)
  test_batchnorm_3D_train_NHWC_vs_cpu_mixed_bfloat16 (__main__.TestNN) ... ok (0.004s)
  test_batchnorm_3D_train_NHWC_vs_cpu_mixed_float16 (__main__.TestNN) ... ok (0.004s)
  test_batchnorm_3D_train_NHWC_vs_native_float32 (__main__.TestNN) ... ok (0.011s)
  test_batchnorm_3D_train_NHWC_vs_native_mixed_bfloat16 (__main__.TestNN) ... ok (0.004s)
  test_batchnorm_3D_train_NHWC_vs_native_mixed_float16 (__main__.TestNN) ... ok (0.004s)
```
Old batchnorm tests will have `2D` it their names
```
  test_batchnorm_2D_inference_NCHW_vs_cpu_float32 (__main__.TestNN) ... ok (0.023s)
  test_batchnorm_2D_inference_NCHW_vs_cpu_mixed_bfloat16 (__main__.TestNN) ... ok (0.005s)
  test_batchnorm_2D_inference_NCHW_vs_cpu_mixed_float16 (__main__.TestNN) ... ok (0.005s)
  test_batchnorm_2D_inference_NCHW_vs_native_float32 (__main__.TestNN) ... ok (0.104s)
  test_batchnorm_2D_inference_NCHW_vs_native_mixed_bfloat16 (__main__.TestNN) ... ok (0.004s)
  test_batchnorm_2D_inference_NCHW_vs_native_mixed_float16 (__main__.TestNN) ... ok (0.003s)
  test_batchnorm_2D_inference_NHWC_vs_NCHW_float32 (__main__.TestNN) ... ok (0.020s)
  test_batchnorm_2D_inference_NHWC_vs_NCHW_mixed_bfloat16 (__main__.TestNN) ... ok (0.004s)
  test_batchnorm_2D_inference_NHWC_vs_NCHW_mixed_float16 (__main__.TestNN) ... ok (0.004s)
  test_batchnorm_2D_inference_NHWC_vs_cpu_float32 (__main__.TestNN) ... ok (0.004s)
  test_batchnorm_2D_inference_NHWC_vs_cpu_mixed_bfloat16 (__main__.TestNN) ... ok (0.003s)
  test_batchnorm_2D_inference_NHWC_vs_cpu_mixed_float16 (__main__.TestNN) ... ok (0.003s)
  test_batchnorm_2D_inference_NHWC_vs_native_float32 (__main__.TestNN) ... ok (0.003s)
  test_batchnorm_2D_inference_NHWC_vs_native_mixed_bfloat16 (__main__.TestNN) ... ok (0.003s)
  test_batchnorm_2D_inference_NHWC_vs_native_mixed_float16 (__main__.TestNN) ... ok (0.003s)
  test_batchnorm_2D_train_NCHW_vs_cpu_float32 (__main__.TestNN) ... ok (0.011s)
  test_batchnorm_2D_train_NCHW_vs_cpu_mixed_bfloat16 (__main__.TestNN) ... ok (0.006s)
  test_batchnorm_2D_train_NCHW_vs_cpu_mixed_float16 (__main__.TestNN) ... ok (0.006s)
  test_batchnorm_2D_train_NCHW_vs_native_float32 (__main__.TestNN) ... ok (0.004s)
  test_batchnorm_2D_train_NCHW_vs_native_mixed_bfloat16 (__main__.TestNN) ... skip: bfloat16 NCHW train failed due to native tolerance issue SWDEV-507600 (0.002s)
  test_batchnorm_2D_train_NCHW_vs_native_mixed_float16 (__main__.TestNN) ... ok (0.004s)
  test_batchnorm_2D_train_NHWC_vs_NCHW_float32 (__main__.TestNN) ... ok (0.006s)
  test_batchnorm_2D_train_NHWC_vs_NCHW_mixed_bfloat16 (__main__.TestNN) ... ok (0.006s)
  test_batchnorm_2D_train_NHWC_vs_NCHW_mixed_float16 (__main__.TestNN) ... ok (0.006s)
  test_batchnorm_2D_train_NHWC_vs_cpu_float32 (__main__.TestNN) ... ok (0.004s)
  test_batchnorm_2D_train_NHWC_vs_cpu_mixed_bfloat16 (__main__.TestNN) ... ok (0.004s)
  test_batchnorm_2D_train_NHWC_vs_cpu_mixed_float16 (__main__.TestNN) ... ok (0.004s)
  test_batchnorm_2D_train_NHWC_vs_native_float32 (__main__.TestNN) ... ok (0.004s)
  test_batchnorm_2D_train_NHWC_vs_native_mixed_bfloat16 (__main__.TestNN) ... ok (0.004s)
  test_batchnorm_2D_train_NHWC_vs_native_mixed_float16 (__main__.TestNN) ... ok (0.004s)
```

Tested in `compute-rocm-dkms-no-npi-hipclang` image build 16062:
`compute-artifactory.amd.com:5000/rocm-plus-docker/framework/compute-rocm-dkms-no-npi-hipclang:16062_ubuntu22.04_py3.10_pytorch_lw_release-2.7_1fee1967`

Tests can be run with environment variable `MIOPEN_ENABLE_LOGGING_CMD=1`
to collect MIOpenDriver commands

```
MIOPEN_ENABLE_LOGGING_CMD=1 python test_nn.py -v -k test_batchnorm_3D_train_NHWC_vs_NCHW_mixed_bfloat16

test_batchnorm_3D_train_NHWC_vs_NCHW_mixed_bfloat16 (__main__.TestNN) ... 
MIOpen(HIP): Command [LogCmdBNorm] ./bin/MIOpenDriver bnormbfp16 -n 4 -c 8 -D 2 -H 2 -W 2 -m 1 --forw 1 -b 0 -r 1 -s 1 --layout NDHWC
MIOpen(HIP): Command [LogCmdBNorm] ./bin/MIOpenDriver bnormbfp16 -n 4 -c 8 -D 2 -H 2 -W 2 -m 1 --forw 0 -b 1 -s 1 --layout NDHWC
MIOpen(HIP): Command [LogCmdBNorm] ./bin/MIOpenDriver bnormbfp16 -n 4 -c 8 -D 2 -H 2 -W 2 -m 1 --forw 1 -b 0 -r 1 -s 1 --layout NCDHW
MIOpen(HIP): Command [LogCmdBNorm] ./bin/MIOpenDriver bnormbfp16 -n 4 -c 8 -D 2 -H 2 -W 2 -m 1 --forw 0 -b 1 -s 1 --layout NCDHW

ok
```

Co-authored-by: Jeff Daily <[email protected]>
@jithunnair-amd jithunnair-amd changed the title [AUTOGENERATED] [release/2.7] [release/2.6] Add 3D batchnorm tests [AUTOGENERATED] [release/2.7] Add 3D batchnorm tests Jun 4, 2025
@jithunnair-amd jithunnair-amd marked this pull request as ready for review June 4, 2025 23:32
@okakarpa okakarpa mentioned this pull request Jun 4, 2025
Merged
@jithunnair-amd jithunnair-amd merged commit 5631e07 into release/2.7 Jun 4, 2025
@jithunnair-amd jithunnair-amd deleted the autogenerated/release/2.7_cherry-pick_pr-2214 branch June 4, 2025 23:33
pragupta pushed a commit that referenced this pull request Jul 21, 2025
@okakarpa @dnikolaev-amd
@jeffdaily @pragupta
[AUTOGENERATED] [release/2.7] Add 3D batchnorm tests (#2243)
ba97745 
Cherry-pick of #2214

Co-authored-by: Dmitry Nikolaev <[email protected]>
Co-authored-by: Jeff Daily <[email protected]>
(cherry picked from commit 5631e07)
pragupta pushed a commit to pragupta/pytorch that referenced this pull request Jul 21, 2025
@okakarpa @dnikolaev-amd
@jeffdaily @pragupta
[AUTOGENERATED] [release/2.7] Add 3D batchnorm tests (ROCm#2243)
7b89af3 
Cherry-pick of ROCm#2214

Co-authored-by: Dmitry Nikolaev <[email protected]>
Co-authored-by: Jeff Daily <[email protected]>
(cherry picked from commit 5631e07)
pragupta pushed a commit that referenced this pull request Jul 22, 2025
@okakarpa @dnikolaev-amd
@jeffdaily @pragupta
[AUTOGENERATED] [release/2.7] Add 3D batchnorm tests (#2243)
afd3010 
Cherry-pick of #2214

Co-authored-by: Dmitry Nikolaev <[email protected]>
Co-authored-by: Jeff Daily <[email protected]>
(cherry picked from commit 5631e07)
jithunnair-amd pushed a commit that referenced this pull request Jul 22, 2025
@okakarpa @dnikolaev-amd
@jeffdaily @jithunnair-amd
[AUTOGENERATED] [release/2.7] Add 3D batchnorm tests (#2243)
e4d62b1 
Cherry-pick of #2214

Co-authored-by: Dmitry Nikolaev <[email protected]>
Co-authored-by: Jeff Daily <[email protected]>
(cherry picked from commit 5631e07)
pragupta pushed a commit that referenced this pull request Jul 29, 2025
@okakarpa @dnikolaev-amd
@jeffdaily @pragupta
[AUTOGENERATED] [release/2.7] Add 3D batchnorm tests (#2243)
d568c28 
Cherry-pick of #2214

Co-authored-by: Dmitry Nikolaev <[email protected]>
Co-authored-by: Jeff Daily <[email protected]>
(cherry picked from commit 5631e07)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@okakarpa @jithunnair-amd @dnikolaev-amd