[SOW MS3] [ROCm] unskip external streams tests#1033
Merged
jithunnair-amd merged 1 commit intosow_ms3from Jul 7, 2022
Merged
Conversation
Collaborator
Author
|
CI failure not due to this PR. The enabled test is passing within test2 suite. |
jithunnair-amd
approved these changes
Jul 7, 2022
akashveramd
pushed a commit
that referenced
this pull request
Jun 13, 2025
To enable chunked loss, I refactor the `train_spec.loss_fn` to `train_spec.build_loss_fn` as suggested in #996 Also: - Unified chunked loss implementation with the `cross_entropy_loss` name, since default is a special case with chunk=1. Identical loss and memory: <img width="1257" alt="Screenshot 2025-03-30 at 13 03 44" src="https://github.com/user-attachments/assets/11c07849-2340-4b42-ad5c-d96657ee53b9" /> - Enable compiling the loss function as it's working fine for me, and result in reduction of memory and slightly better througput. <img width="1275" alt="Screenshot 2025-03-30 at 16 47 00" src="https://github.com/user-attachments/assets/09edaf16-1770-48da-87b2-e4de29e7519c" /> While we only have one type of loss, I create a field for `loss.name` with default to 'cross_entropy' to be fork-friendly anyway. Co-authored-by: tianyu-l <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.