Skip to content

[SOW MS3] [ROCm] unskip external streams tests#1033

Merged
jithunnair-amd merged 1 commit intosow_ms3from
sow_ms3_external_streams
Jul 7, 2022
Merged

[SOW MS3] [ROCm] unskip external streams tests#1033
jithunnair-amd merged 1 commit intosow_ms3from
sow_ms3_external_streams

Conversation

@jeffdaily
Copy link
Copy Markdown
Collaborator

No description provided.

@jeffdaily
Copy link
Copy Markdown
Collaborator Author

CI failure not due to this PR. The enabled test is passing within test2 suite.

15:25:54   test_external_streams (__main__.TestCuda) ... ok (0.046s)
15:25:54   test_external_streams_multi_device (__main__.TestCuda) ... skip: detected only one GPU (0.001s)

@jithunnair-amd jithunnair-amd merged commit c3d41b7 into sow_ms3 Jul 7, 2022
@jithunnair-amd jithunnair-amd changed the title [ROCm] unskip external streams tests [SOW MS3] [ROCm] unskip external streams tests Jul 13, 2022
akashveramd pushed a commit that referenced this pull request Jun 13, 2025
To enable chunked loss, I refactor the `train_spec.loss_fn` to
`train_spec.build_loss_fn` as suggested in #996

 Also:
- Unified chunked loss implementation with the `cross_entropy_loss`
name, since default is a special case with chunk=1.
Identical loss and memory:

<img width="1257" alt="Screenshot 2025-03-30 at 13 03 44"
src="https://github.com/user-attachments/assets/11c07849-2340-4b42-ad5c-d96657ee53b9"
/>

- Enable compiling the loss function as it's working fine for me, and
result in reduction of memory and slightly better througput.

<img width="1275" alt="Screenshot 2025-03-30 at 16 47 00"
src="https://github.com/user-attachments/assets/09edaf16-1770-48da-87b2-e4de29e7519c"
/>

While we only have one type of loss, I create a field for `loss.name`
with default to 'cross_entropy' to be fork-friendly anyway.

Co-authored-by: tianyu-l <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants