Add safety check so that TransposeBigMLFloat16 test passes#77
Merged
TedThemistokleous merged 2 commits intorocm6.3_internal_testingfrom Nov 19, 2024
Merged
Conversation
…ap kernel so that TransposeBigMLFloat16 test passes
Collaborator
|
fix format using their lintrunner -a tool |
sstamenk
changed the title
| return rocblas_dgeam(handle, transa, transb, m, n, alpha, A, lda, beta, B, ldb, C, ldc); | ||
| } | ||
|
|
||
| inline bool CanUse_rocblasTransposeHelper_MLFloat16(int /*m*/, int /*n*/) { return true; } // CUDA has a limited grid size of 65536, ROCm has higher limits. |
Collaborator
There was a problem hiding this comment.
Why did you remove the inline here?
Member
Author
There was a problem hiding this comment.
I moved the implementation of the function inside fpgeneric.cu to mirror the way it was done inside CUDA EP.
Collaborator
|
Upstreaming this. |
sstamenk
changed the title
TedThemistokleous
pushed a commit
that referenced
this pull request
Jan 3, 2025
* Added maximum gridDim.y overflow heck before calling transposeNoOverlap kernel so that TransposeBigMLFloat16 test passes * Fix formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a check that queries hipGetDeviceProperties and returns false if gridDim.y is larger than the device maximum supported gridDim.y.
This check existed inside CUDA EP but was absent from ROCM EP and as a result TransposeBigMLFloat16 test was failing.