Force hipify to use copied version from rocm-6.3.0-14776 build#69
Merged
TedThemistokleous merged 3 commits intorocm6.3_internal_testingfrom Oct 10, 2024
Merged
Conversation
causten
reviewed
Oct 10, 2024
Collaborator
causten
left a comment
causten
left a comment
There was a problem hiding this comment.
Does this need to be merged upstream? Would the path for hipify-perl be appropriate? Seems like you are suggesting it belongs in the root.
xinyazhang
requested changes
Oct 10, 2024
xinyazhang
left a comment
xinyazhang
left a comment
There was a problem hiding this comment.
hipify-perl should be placed under the same directory of amd_hipify.py rather than root of the source tree, unless there is really good reason.
This is a temporary solution and we are working on another PR that eliminates onnxruntime/tools/ci_build/amd_hipify.py Line 14 in 2580d93 , which should work for newer hipify-perl |
Collaborator
Author
Done. Just retesting this. and will update once done. |
Collaborator
Author
No it shouldn't for now. The plan is to revert this once the changes for hipify are done here for the ROCm EP |
Collaborator
Author
|
Moved it and had to update permissions. Looks like its built and working minus some other test thats failed
|
xinyazhang
requested changes
Oct 10, 2024
xinyazhang
left a comment
xinyazhang
left a comment
There was a problem hiding this comment.
Do not use absolute path. Compute it in your amd_hipify.py
tools/ci_build/amd_hipify.py
Outdated
| args = parser.parse_args() | ||
|
|
||
| hipify(args.hipify_perl, args.src, args.output) | ||
| hipify("/onnxruntime/tools/ci_build/hipify-perl", args.src, args.output) |
There was a problem hiding this comment.
Use
hipify(os.path.join(os.path.dirname(__file__), "hipify-perl"), args.src, args.output)Instead
Collaborator
Author
There was a problem hiding this comment.
Done - retested this and works
xinyazhang
approved these changes
Oct 10, 2024
TedThemistokleous
added a commit
that referenced
this pull request
Jan 3, 2025
* Force hipify to use copied version from rocm-6.3.0-14776 build * Update hipify-perl location and permissions * Update hipify path to remove absolute path
streamhsa
pushed a commit
that referenced
this pull request
May 22, 2025
Required so we can convert kernels with the latest hipify that supports latest hipblas change - Remove hipify-perl version from rocm-6.3.0-14776 build - Use the argument pushed to the amd_hipify.py script. related to #69
TedThemistokleous
added a commit
that referenced
this pull request
May 28, 2025
* Use the latest hipify-perl for ROCm 7.0 instead of pinned version Required so we can convert kernels with the latest hipify that supports latest hipblas change - Remove hipify-perl version from rocm-6.3.0-14776 build - Use the argument pushed to the amd_hipify.py script. related to #69 * Remove roctracer_hcc.h include Not needed as roctracer_hip.h superceeds this * Removal of hipblas_v2_api reference Just make this use hipblas directly * Use local system hipify no os path join needed * Add HIPIFY Path log mesasge for build
TedThemistokleous
added a commit
to TedThemistokleous/onnxruntime
that referenced
this pull request
May 28, 2025
* Use the latest hipify-perl for ROCm 7.0 instead of pinned version Required so we can convert kernels with the latest hipify that supports latest hipblas change - Remove hipify-perl version from rocm-6.3.0-14776 build - Use the argument pushed to the amd_hipify.py script. related to ROCm#69 * Remove roctracer_hcc.h include Not needed as roctracer_hip.h superceeds this * Removal of hipblas_v2_api reference Just make this use hipblas directly * Use local system hipify no os path join needed * Add HIPIFY Path log mesasge for build
tianleiwu
pushed a commit
to microsoft/onnxruntime
that referenced
this pull request
Jun 5, 2025
* Use the latest hipify-perl for ROCm 7.0 instead of pinned version Required so we can convert kernels with the latest hipify that supports latest hipblas change - Remove hipify-perl version from rocm-6.3.0-14776 build - Use the argument pushed to the amd_hipify.py script. related to ROCm#69 * Remove roctracer_hcc.h include Not needed as roctracer_hip.h superceeds this * Removal of hipblas_v2_api reference Just make this use hipblas directly * Use local system hipify no os path join needed * Add HIPIFY Path log mesasge for build ### Description <!-- Describe your changes. --> Update to use the local version of hipify from the ROCm release. Relevant since we'd like to ensure the latest hipify changes are being used and being tested when using ROCm EP ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> Latest and greatest for ROCm EP to convert kernels via hipify-perl mechanism Co-authored-by: Ted Themistokleous <[email protected]>
javier-intel
pushed a commit
to intel/onnxruntime
that referenced
this pull request
Jun 15, 2025
…4885) * Use the latest hipify-perl for ROCm 7.0 instead of pinned version Required so we can convert kernels with the latest hipify that supports latest hipblas change - Remove hipify-perl version from rocm-6.3.0-14776 build - Use the argument pushed to the amd_hipify.py script. related to ROCm#69 * Remove roctracer_hcc.h include Not needed as roctracer_hip.h superceeds this * Removal of hipblas_v2_api reference Just make this use hipblas directly * Use local system hipify no os path join needed * Add HIPIFY Path log mesasge for build ### Description <!-- Describe your changes. --> Update to use the local version of hipify from the ROCm release. Relevant since we'd like to ensure the latest hipify changes are being used and being tested when using ROCm EP ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> Latest and greatest for ROCm EP to convert kernels via hipify-perl mechanism Co-authored-by: Ted Themistokleous <[email protected]>
quic-ankus
pushed a commit
to CodeLinaro/onnxruntime
that referenced
this pull request
Nov 25, 2025
…crosoft#24885) * Use the latest hipify-perl for ROCm 7.0 instead of pinned version Required so we can convert kernels with the latest hipify that supports latest hipblas change - Remove hipify-perl version from rocm-6.3.0-14776 build - Use the argument pushed to the amd_hipify.py script. related to ROCm#69 * Remove roctracer_hcc.h include Not needed as roctracer_hip.h superceeds this * Removal of hipblas_v2_api reference Just make this use hipblas directly * Use local system hipify no os path join needed * Add HIPIFY Path log mesasge for build ### Description <!-- Describe your changes. --> Update to use the local version of hipify from the ROCm release. Relevant since we'd like to ensure the latest hipify changes are being used and being tested when using ROCm EP ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> Latest and greatest for ROCm EP to convert kernels via hipify-perl mechanism Co-authored-by: Ted Themistokleous <[email protected]>
apwojcik
pushed a commit
that referenced
this pull request
Jan 26, 2026
Some PRs that use core/common/inlined_containers.h can cause failures in the CUDA CI pipeline. ``` E:\_work\_temp\build\RelWithDebInfo\vcpkg_installed\x64-windows-static-md\include\absl/hash/internal/hash.h(481): error #68-D: integer conversion resulted in a change of sign [E:\_work\_temp\build\RelWithDebInfo\onnxruntime_providers_cuda.vcxproj] sizeof(T) == -1, ^ Remark: The warnings can be suppressed with "-diag-suppress <warning-number>" E:\_work\_temp\build\RelWithDebInfo\vcpkg_installed\x64-windows-static-md\include\absl/hash/hash.h(337): error microsoft#549-D: variable "s" is used before its value is set [E:\_work\_temp\build\RelWithDebInfo\onnxruntime_providers_cuda.vcxproj] return s; ^ E:\_work\_temp\build\RelWithDebInfo\vcpkg_installed\x64-windows-static-md\include\absl/container/internal/raw_hash_set.h(468): error #69-D: integer conversion resulted in truncation [E:\_work\_temp\build\RelWithDebInfo\onnxruntime_providers_cuda.vcxproj] static_cast<uint16_t>(reinterpret_cast<uintptr_t>(&seed)); ^ 3 errors detected in the compilation of "E:/_work/onnxruntime/onnxruntime/onnxruntime/contrib_ops/cuda/sparse/block_mask.cu". ``` This change adds a patch to Abseil to mitigate those failures. This solution has been verified to be effective in PR microsoft#27087.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Copied out hipifiy-perl from working docker container as mentioned by @xinyazhang
Retargeted amd_hipify to use the copied item found in onnxruntime root
Motivation and Context
Changed as an upstream change to the rocm stack requires a bunch of work required to get a working rebuild of ROCm EP.
Currently this inhibits development and blocks 6.3 wheel builds