Skip to content

Add rocm to transformers/benchmark.py script#68

Merged
TedThemistokleous merged 1 commit intorocm6.2_internal_testingfrom
add_rocm_to_benchmark
Oct 2, 2024
Merged

Add rocm to transformers/benchmark.py script#68
TedThemistokleous merged 1 commit intorocm6.2_internal_testingfrom
add_rocm_to_benchmark

Conversation

@stsokolo
Copy link

@stsokolo stsokolo commented Oct 2, 2024

No description provided.

@TedThemistokleous TedThemistokleous merged commit 8495918 into rocm6.2_internal_testing Oct 2, 2024
@TedThemistokleous
Copy link
Collaborator

Cherry pick this change and try to commit this to onnxruntime/main to upstream it

@TedThemistokleous
Copy link
Collaborator

@stsokolo also target this to 6.3_internal_testing branch

stsokolo added a commit that referenced this pull request Oct 3, 2024
apwojcik pushed a commit that referenced this pull request Jan 26, 2026
Some PRs that use core/common/inlined_containers.h can cause failures in
the CUDA CI pipeline.

```
E:\_work\_temp\build\RelWithDebInfo\vcpkg_installed\x64-windows-static-md\include\absl/hash/internal/hash.h(481): error #68-D: integer conversion resulted in a change of sign [E:\_work\_temp\build\RelWithDebInfo\onnxruntime_providers_cuda.vcxproj]
          sizeof(T) == -1,
                       ^
  Remark: The warnings can be suppressed with "-diag-suppress <warning-number>"

E:\_work\_temp\build\RelWithDebInfo\vcpkg_installed\x64-windows-static-md\include\absl/hash/hash.h(337): error microsoft#549-D: variable "s" is used before its value is set [E:\_work\_temp\build\RelWithDebInfo\onnxruntime_providers_cuda.vcxproj]
        return s;
               ^
E:\_work\_temp\build\RelWithDebInfo\vcpkg_installed\x64-windows-static-md\include\absl/container/internal/raw_hash_set.h(468): error #69-D: integer conversion resulted in truncation [E:\_work\_temp\build\RelWithDebInfo\onnxruntime_providers_cuda.vcxproj]
          static_cast<uint16_t>(reinterpret_cast<uintptr_t>(&seed));
                      ^
  3 errors detected in the compilation of "E:/_work/onnxruntime/onnxruntime/onnxruntime/contrib_ops/cuda/sparse/block_mask.cu".
```

This change adds a patch to Abseil to mitigate those failures.


This solution has been verified to be effective in PR
microsoft#27087.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants