[libc] Fix unit test dependency and respect LIBC_INCLUDE_BENCHMARKS (…#1414
Merged
ronlieb merged 1 commit intoamd-mainlinefrom Feb 11, 2026
Merged
[libc] Fix unit test dependency and respect LIBC_INCLUDE_BENCHMARKS (…#1414ronlieb merged 1 commit intoamd-mainlinefrom
ronlieb merged 1 commit intoamd-mainlinefrom
Conversation
…lvm#180812) Summary: The unittest framework function is defined in another CMake file which may not be present if the uesr disabled tests, provide a smaller version here to keep this private. Also respesct the LIBC_INCLUDE_BENCHMARKS variable.
ronlieb
added a commit
to ROCm/TheRock
that referenced
this pull request
Feb 11, 2026
Updates for building amdgcn-amd-amdhsa/libflang_rt.runtime.a Necessary to fix various smoke failures, such as data_share1 depends on PR ROCm/llvm-project#1414 being present in llvm avoids libc benchmark build failures.
carlobertolli
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…llvm#180812)
Summary:
The unittest framework function is defined in another CMake file which may not be present if the uesr disabled tests, provide a smaller version here to keep this private. Also respesct the LIBC_INCLUDE_BENCHMARKS variable.