Add structural sparsity gemm instruction tests#1309
Merged
Conversation
jakpiase
requested review from
aosewski,
carlushuang,
illsilin,
junliume and
zjing14
as code owners
Silv3S
approved these changes
May 24, 2024
aosewski
requested changes
May 29, 2024
Collaborator
aosewski
left a comment
aosewski
left a comment
There was a problem hiding this comment.
In general looks good. But please write unit tests using gtest.
aosewski
reviewed
Jun 26, 2024
aosewski
reviewed
Jun 26, 2024
aosewski
requested changes
Jun 26, 2024
Collaborator
aosewski
left a comment
aosewski
left a comment
There was a problem hiding this comment.
Just a few minor changes to tests.
aosewski
approved these changes
Jun 27, 2024
junliume
reviewed
Jul 3, 2024
| if(GPU_TARGETS MATCHES "gfx11") | ||
| add_subdirectory(wmma_op) | ||
| endif() | ||
| if(GPU_TARGETS MATCHES "gfx942") |
Contributor
There was a problem hiding this comment.
I guess this is problematic because if one also targets other platforms, this will also get built and causing unsupported instructions error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added single wavefront tests of AMD's structural sparsity matrix multiplication instructions. Currently following instructions are supported: