Conversation
Member
Author
|
Plan for this PR is to be merged as soon as it builds -- its purpose is to make sure that both 0.8 and upcoming 0.9 can somehow coexist in the current RIOT tree until 0.9 is out. If we do need to do any updates to RIOT before all breaking changes are through, we can still fork off here^ into a v08 branch, and keep merging fixes into that. |
chrysn
force-pushed
the
v09
branch
3 times, most recently
from
1bb20da to
9253234
Compare
This is a breaking change because heapless is a public dependency.
The `Never` helper still exists, because it is necessary to implement traits such as Termination for `!`, and to express that an input closure must not terminate, but the public error types are changed. While this is a breaking change that was not preceded by a deprecation, it is unlikely people match on the precise type (and all error conversions should be implemented or implementable on both types).
…it (ADC) SPI is not dropped either because the 1.0 trait includes acquisition in the trait (which makes it not trivial to port). Closes: #65
This merely acknowledges that the 0.8 branch had changes. It works around the current GitHub CI configuration that won't start CI as long as a branch can't be merged with main.
This makes implicit what caused breakage in b99e808: embedded-nal{,-async}'s socket types are re-exports of no_std_net (and thus public dependencies). Conversions are now implemented explicitly for the relevant no_std_net versions.
... and use it in owned form more frequently Closes: #64
This needed serious adjustments due to extensions to the ZTimer implementation.
This is still what most users will expect to do; documentation points out a way with less overhead.
This was referenced Aug 20, 2024
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This kicks off a new breaking change, including a first trivial breaking change (the heapless upgrade necessary for #89, which needs no further changes).