Conversation
Member
Author
|
Testing is a bit odd because we can't rely on CI (after all, #141 passed) and I don't want to add just another board for this PR. I tested this by running in |
This was referenced Jan 13, 2025
Member
Author
|
Just Also tested with I'm setting this to draft, tough, because on |
Teufelchen1
reviewed
Jan 13, 2025
Contributor
Teufelchen1
left a comment
Teufelchen1
left a comment
There was a problem hiding this comment.
LGTM but not sure if I can assess the in-depth implications of this.
chrysn
added a commit
to chrysn-pull-requests/RIOT
that referenced
this pull request
Jan 13, 2025
This pulls in the changes of [144]. [144]: RIOT-OS/rust-riot-wrappers#144
AnnsAnns
pushed a commit
to AnnsAnns/RIOT
that referenced
this pull request
Jan 15, 2025
This pulls in the changes of [144]. [144]: RIOT-OS/rust-riot-wrappers#144
dprigoshij
pushed a commit
to dprigoshij/RIOT
that referenced
this pull request
Mar 24, 2025
This pulls in the changes of [144]. [144]: RIOT-OS/rust-riot-wrappers#144
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When testing them with full RIOT, #141 had errors like this:
This PR uses the cfg(accessible()) emulation to switch around between how the value is best accessed.