Closed
Conversation
chrysn
added a commit
to RIOT-OS/rust-riot-wrappers
that referenced
this pull request
Feb 20, 2023
The metadata is not correct in this commit: This will need riot-sys 0.7.10, but that's not released yet -- not even its main branch contains RIOT-OS/rust-riot-sys#19 so far.
chrysn
added a commit
to RIOT-OS/rust-riot-wrappers
that referenced
this pull request
Feb 20, 2023
The metadata is not correct in this commit: This will need riot-sys 0.7.10, but that's not released yet -- not even its main branch contains RIOT-OS/rust-riot-sys#19 so far.
Member
Author
|
Abandoned in favor of #21 and a local solution in riot-wrappers. |
chrysn
added a commit
to RIOT-OS/rust-riot-wrappers
that referenced
this pull request
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checks the generated source for a precise line (
pub const CONFIG_AUTO_INIT_ENABLE_DEBUG: u32 = 1;) and if present, sets the marker.The
=1comparison is not too weird because the input to this has been passed through genconfigheader.sh, which ensures that no weird values (eg.=2) show up.The whole line is weird because so far I've used markers to tell whether or not something has become part of the RIOT source, not to check for flags.
It may be practical to do a run through all the items passed through genconfigheader.sh (and thus found in riotbuild.h) for flags which might be enabled but would need checking at build time.
So to summarize, I'm not sure yet this is a good approach -- putting it here a) for review and b) to have a branch that can be used by auto-init users (who need some information like this in order to properly initialize their auto_init_module_t strucs).