esp8266: replacement of SDK library printf functions#95
Merged
kaspar030 merged 2 commits intoRIOT-OS:masterfrom Feb 8, 2020
Merged
esp8266: replacement of SDK library printf functions#95kaspar030 merged 2 commits intoRIOT-OS:masterfrom
kaspar030 merged 2 commits intoRIOT-OS:masterfrom
Conversation
In order to be able to control the log output from SDK libraries according to the defined log level, a number of library-specific printf functions were implemented in RIOT with PR 12998 for use by the SDK. These library-specific printf functions intercept the log output of the SDK and redirect it to the RIOT log macros. To get these SDK library specific functions working, the printf/ets_printf calls in SDK libraries have to be replaced.
gschorcht
force-pushed
the
esp8266_rtos_sdk_lib_printf
branch
from
5a21366 to
a6e4b1d
Compare
Contributor
Author
|
@kaspar030 Since PR RIOT-OS/RIOT#12998 was released with 2020.01, we should change now the toolchain to make it effective for ESP8266. |
kaspar030
approved these changes
Feb 8, 2020
Contributor
kaspar030
left a comment
kaspar030
left a comment
There was a problem hiding this comment.
ACK. CI builds succeeded, should be sufficient.
Contributor
Author
|
Thanks for merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR just references another commit c0174ef of the ESP8266 toolchain repository which simply contains a number of function call replacements in SDK libraries.
Background
In order to be able to control the log output from ESP8266 SDK libraries according to the defined log level, a number of library-specific
printffunctions were implemented in RIOT with PR #12998 for use by the SDK. These library-specificprintffunctions intercept the log output of the SDK and redirect it to the RIOT log macros.To get these SDK library-specific functions working, all
printf/ets_printfcalls in SDK libraries have to be replaced by the calls of the library-specificprintffunctions.Dependencies
Depends on PR #12998 (PR #12998 has to be merged before this change can be merged. Otherwise, compilation errors of RIOT for ESP8266 will occur.)