Skip to content

travis: add riot testbuild#72

Merged
kaspar030 merged 1 commit intoRIOT-OS:masterfrom
kaspar030:add_riot_testbuild
May 6, 2019
Merged

travis: add riot testbuild#72
kaspar030 merged 1 commit intoRIOT-OS:masterfrom
kaspar030:add_riot_testbuild

Conversation

@kaspar030
Copy link
Copy Markdown
Contributor

@kaspar030 kaspar030 commented Apr 11, 2019 •
edited
Loading

This PR tries to add a build of hello-world for all installed toolchains.

The idea is to get a basic notion of whether the container is able to build RIOT.
I have randomly selected one board for each installed toolchain.

@kaspar030 kaspar030 requested a review from miri64 April 11, 2019 21:24
@kaspar030 kaspar030 force-pushed the add_riot_testbuild branch 2 times, most recently from 3e977a4 to 4e4d8ad Compare April 11, 2019 21:32
@kaspar030 kaspar030 mentioned this pull request Apr 12, 2019
Merged
@kaspar030 kaspar030 force-pushed the add_riot_testbuild branch from 0d9d984 to db03cf5 Compare April 12, 2019 07:30
@kaspar030
Copy link
Copy Markdown
Contributor Author

kaspar030 commented Apr 12, 2019

Ok, now I got it right. ;) @miri64 wanna take a look?

miri64
miri64 requested changes May 6, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits

.travis.yml
- sed -i '35i\ \ BOARDS \\' RIOT/makefiles/docker.inc.mk
- DOCKER_IMAGE=riotdocker:latest
BUILD_IN_DOCKER=1
BOARDS="arduino-uno esp32-wroom-32 hifive1 msb-430h native pic32-wifire samr21-xpro"
Copy link
Copy Markdown
Member

@miri64 miri64 May 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to add also native:llvm and samr21-xpro:llvm?

Copy link
Copy Markdown
Contributor Author

@kaspar030 kaspar030 May 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

.travis.yml Outdated
script:
- docker build -t riotdocker .
- docker image ls riotdocker:latest
- git clone --depth 1 https://github.com/RIOT-OS/RIOT -b 2019.01
Copy link
Copy Markdown
Member

@miri64 miri64 May 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2019.04?

Copy link
Copy Markdown
Contributor Author

@kaspar030 kaspar030 May 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

.travis.yml
- docker build -t riotdocker .
- docker image ls riotdocker:latest
- git clone --depth 1 https://github.com/RIOT-OS/RIOT -b 2019.01
- sed -i '35i\ \ BOARDS \\' RIOT/makefiles/docker.inc.mk
Copy link
Copy Markdown
Member

@miri64 miri64 May 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this?

Copy link
Copy Markdown
Contributor Author

@kaspar030 kaspar030 May 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a hint. without the fix, BOARDS won't propagated into the contianer, making this test build everything. We know how travis likes our full builds...

Copy link
Copy Markdown
Member

@miri64 miri64 May 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW. The first two steps would have been better placed in before_script:, but oh well...

@kaspar030
Copy link
Copy Markdown
Contributor Author

kaspar030 commented May 6, 2019

@miri64 I think I got them all

miri64
miri64 approved these changes May 6, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, sad that a second docker buildtest is needed for LLVM, but this is outside the scope of this PR.

@miri64
Copy link
Copy Markdown
Member

miri64 commented May 6, 2019

Please squash.

@kaspar030 kaspar030 force-pushed the add_riot_testbuild branch from 851c815 to 687a75f Compare May 6, 2019 13:51
@miri64
Copy link
Copy Markdown
Member

miri64 commented May 6, 2019

Please prefix commit message ;-).

@kaspar030 kaspar030 force-pushed the add_riot_testbuild branch from 687a75f to c692608 Compare May 6, 2019 13:59
@kaspar030
Copy link
Copy Markdown
Contributor Author

kaspar030 commented May 6, 2019

Please prefix commit message ;-).

yup, did. Thanks for reviewing!

@miri64
Copy link
Copy Markdown
Member

miri64 commented May 6, 2019

Re-ACK

@kaspar030 kaspar030 merged commit af1f432 into RIOT-OS:master May 6, 2019
@kaspar030 kaspar030 deleted the add_riot_testbuild branch May 6, 2019 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miri64 miri64 miri64 approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kaspar030 @miri64