Merged
Conversation
Contributor
|
There's already a new release of the toolchain. Maybe use this one ? |
kaspar030
changed the title
Contributor
Author
|
This was referenced Jul 19, 2019
fjmolinas
reviewed
Aug 8, 2019
Contributor
fjmolinas
left a comment
fjmolinas
left a comment
There was a problem hiding this comment.
I was able to build the docker Image successfully. I only have one question, see below.
| cd - | ||
|
|
||
| # HACK download arch linux' flex dynamic library | ||
| RUN wget -q https://sgp.mirror.pkgbuild.com/core/os/x86_64/flex-2.6.4-2-x86_64.pkg.tar.xz -O- \ |
Contributor
There was a problem hiding this comment.
Why was this needed before and why is is not needed anymore?
Contributor
Author
There was a problem hiding this comment.
See #39, libfl on ubuntu is somehow weird. the riscv toolchain could not use it. thus we used arch linux' libfl package.
The current risc-v toolchain comes bundled with libfl, thus the hack is not needed anymore.
fjmolinas
approved these changes
Aug 9, 2019
Contributor
fjmolinas
left a comment
fjmolinas
left a comment
There was a problem hiding this comment.
Untested-ACK, since I don't have any hardware to test this.
Contributor
Author
|
Thanks @fjmolinas! &go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current risc-v toolchain makes some applications not pass the tests.
This gcc 8.1 based one works fine. I didn't dig for reasons. My gut feeling is that the newly available newlib-nano saves enough stack space to not break the tests.
Supercedes #62.
Waiting for #70.