apt: Use --no-install-recommends to avoid unnecessary extras #59
Merged
jnohlgard merged 2 commits intoRIOT-OS:masterfrom Nov 20, 2018
Merged
apt: Use --no-install-recommends to avoid unnecessary extras #59jnohlgard merged 2 commits intoRIOT-OS:masterfrom
jnohlgard merged 2 commits intoRIOT-OS:masterfrom
Conversation
Contributor
|
I will run the buildtest during the release with this version. |
Member
Author
|
Thanks, @cladmi! |
54 tasks
Contributor
|
I ran the compilation test with this, I will merge after the release. |
Contributor
|
Only failed build was tests/gnrc_ipv6_nib but it also fails with the current image.
|
cladmi
suggested changes
Nov 8, 2018
Contributor
cladmi
left a comment
cladmi
left a comment
There was a problem hiding this comment.
I ACK but just wait for the release cycle to be finished for merging.
Member
Author
|
Thanks, @cladmi! |
Merged
Contributor
|
@smlng @kaspar030 do you see any other checks that should be done ? like for using it in murdock or something I missed |
cladmi
approved these changes
Nov 19, 2018
Contributor
cladmi
left a comment
cladmi
left a comment
There was a problem hiding this comment.
ACK. There were no objections said on this one.
Please rebase and merge when travis is happy.
jnohlgard
force-pushed
the
pr/norecommends
branch
from
b22f7c7 to
9d44f26
Compare
Member
Author
|
Rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
--no-install-recommendsto apt-get commands to avoid pulling in optional dependencies which are not used by the build process.The image size reduction is approximately 430 MB
Testing
This needs a full buildtest run on the new image to ensure that no critical components are missing after adding this flag, but my laptop does not have the disk space or time to do it.