Less layers by joining commands#3
Merged
OlegHahm merged 2 commits intoRIOT-OS:masterfrom May 21, 2015
Merged
Conversation
Member
|
I have no idea about docker, but the explanation sounds reasonable and the change seems valid. ACK and go! |
OlegHahm
added a commit
that referenced
this pull request
May 21, 2015
Less layers by joining commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each
RUNcommand in the Dockerfile adds a file system layer to the container. Joining commands on a single line using&&results in less layers and less overhead.This joins the update and dist-upgrade commands on a single line, there is really no use for them as separate layers.