Skip to content

riotbuild: Install Rust (minimal edition)#152

Merged
bors[bot] merged 1 commit intoRIOT-OS:masterfrom
chrysn-pull-requests:with-minimal-rust
Sep 1, 2021
Merged

riotbuild: Install Rust (minimal edition)#152
bors[bot] merged 1 commit intoRIOT-OS:masterfrom
chrysn-pull-requests:with-minimal-rust

Conversation

@chrysn
Copy link
Copy Markdown
Member

@chrysn chrysn commented Sep 1, 2021

The c2rust program (required in addition to Rust itself) is installed
for what is for most intents and purposes a third party container, but
happens to have its sources shipped along the other containers.


This is a minimal version competing with #141 -- we can still get c2rust to fully integrate over time, but right now there's a third party (happens to be me) who publishes a suitable base container, which is not much more or less transparently managed than any other base container (especially immunant/c2rust which it itself is based on), and hey by the way even the Dockerfile for that container is shipped here (but more for informational purposes, not because CI would access it).

The c2rust program (required in addition to Rust itself) is installed
for what is for most intents and purposes a third party container, but
happens to have its sources shipped along the other containers.
@chrysn chrysn mentioned this pull request Sep 1, 2021
@chrysn
Copy link
Copy Markdown
Member Author

chrysn commented Sep 1, 2021

By the way, the container built from this is successfully in use for the riot-examples CI (so successfully that I've started building more in CI than was previously tested, which is why it's red again).

@chrysn chrysn changed the title riotbuild: Install Rust riotbuild: Install Rust (minimal edition) Sep 1, 2021
@kaspar030
Copy link
Copy Markdown
Contributor

bors try

bors bot added a commit that referenced this pull request Sep 1, 2021
@bors
Copy link
Copy Markdown
Contributor

bors bot commented Sep 1, 2021

try

Build succeeded:

@kaspar030
Copy link
Copy Markdown
Contributor

Regular builds seem to still work, so lets go.

bors merge

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Sep 1, 2021

👎 Rejected by too few approved reviews

@kaspar030
Copy link
Copy Markdown
Contributor

bors merge

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Sep 1, 2021

Build succeeded:

@bors bors bot merged commit d4e7ed0 into RIOT-OS:master Sep 1, 2021
@kaspar030
Copy link
Copy Markdown
Contributor

Unfortunately due to Docker not doing auto builds anymore, this won't be used for Murdock until I move the murdock container builds somewhere else. That's high on my list...

@chrysn
Copy link
Copy Markdown
Member Author

chrysn commented Sep 2, 2021

Thanks, working to improve from here now. (Given that the trouble building on native with this comes from mismatched LLVM 7.0 and 7.1 (from c2rust-build), I expect best progress after #104.)

Is there anything I can do on the murdock side (being relatively unfamiliar with its inner workings)?

@chrysn chrysn deleted the with-minimal-rust branch September 2, 2021 07:34
@chrysn chrysn mentioned this pull request Nov 11, 2021
bors bot added a commit that referenced this pull request Nov 11, 2021
161: Rust updates r=kaspar030 a=chrysn

* Add what is needed to experiment with AVR (not fully supported for Rust-on-RIOT, but way easier to test being in the docker build as I haven't had AVR toolchains installed around for a long time, though they probably still can be installed easily)
* Update Rust nightly (that's a semi-regular thing since we decided to pin the version in #141 (comment) which also went into #152)

Co-authored-by: chrysn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants