add microcoap example application by Lotterleben · Pull Request #2 · RIOT-OS/applications

Lotterleben · 2015-02-10T18:57:41Z

Add a small microcoap example server along with instructions on how to test it using marz and the Copper Firefox Plugin. Depends on RIOT-OS/RIOT#2383.

jnohlgard · 2015-02-14T16:52:46Z

I can't build this example:

applications/microcoap/endpoints.c:10:13: error: variably modified ‘response’ at file scope
 static char response[response_len] = "";
             ^

arm-none-eabi-gcc (Gentoo 4.8.3 p1.1, pie-0.5.9) 4.8.3

When I change the size to numeric constant 1500 I get the program to build correctly.

Lotterleben · 2015-02-15T20:46:06Z

Yup, that has been fixed, but on the wrong branch it seems. 1 sec.

Lotterleben · 2015-02-15T20:48:44Z

Should build now :)

miri64 · 2015-02-20T08:28:38Z

microcoap/Makefile

Remove the out-commented flag

Lotterleben · 2015-02-24T16:12:07Z

@LudwigOrtmann @authmillenon
I'm sorry, but I'm gong to have to ask again– I re-implemented get_hw_addr() now as suggested, but I'm still not content with the way it is now– the user may not have to constantly adjust the hwaddr in marz.config if they use -i, but they'll have to do it once (because I have no idea for which -i get_hw_addr() will return 1, which is the default hwaddr i marz.config).
And I just don't get what's wrong with just returning sysconfig.id and telling the user to start the native instance which they want to be connected to marz with-i 1?

Lotterleben · 2015-02-24T16:42:15Z

Aaaah, because it will break other things -.- sighs

miri64 · 2015-03-04T13:43:52Z

Looks good, please squash.

Lotterleben · 2015-03-04T14:04:25Z

Done :)

miri64 · 2015-03-04T14:14:57Z

"make" -C /home/martine/Repositories/RIOT-OS/RIOT/pkg/microcoap/microcoap
/home/martine/Repositories/RIOT-OS/applications/microcoap/endpoints.c:10:13: error: variably modified ‘response’ at file scope
 static char response[response_len] = "";

with gcc

"make" -C /home/martine/Repositories/RIOT-OS/RIOT/pkg/microcoap/microcoap
/home/martine/Repositories/RIOT-OS/applications/microcoap/endpoints.c:10:13: error: variable length array declaration not
      allowed at file scope
static char response[response_len] = "";
            ^        ~~~~~~~~~~~~
/home/martine/Repositories/RIOT-OS/applications/microcoap/endpoints.c:20:80: warning: unused parameter 'inpkt'
      [-Wunused-parameter]
static int handle_get_response(coap_rw_buffer_t *scratch, const coap_packet_t *inpkt, coap_packet_t *outpkt, uint8_t id...
                                                                               ^
/home/martine/Repositories/RIOT-OS/applications/microcoap/endpoints.c:20:118: warning: unused parameter 'id_hi'
      [-Wunused-parameter]
  ...handle_get_response(coap_rw_buffer_t *scratch, const coap_packet_t *inpkt, coap_packet_t *outpkt, uint8_t id_hi, uint8_...
                                                                                                               ^
/home/martine/Repositories/RIOT-OS/applications/microcoap/endpoints.c:20:133: warning: unused parameter 'id_lo'
      [-Wunused-parameter]
  ...*scratch, const coap_packet_t *inpkt, coap_packet_t *outpkt, uint8_t id_hi, uint8_t id_lo)
                                                                                         ^
3 warnings and 1 error generated.

with clang

edit: same error as reported in #2 (comment)

miri64 · 2015-03-04T14:16:34Z

diff --git a/microcoap/endpoints.c b/microcoap/endpoints.c
index 0c8869e..f6b6967 100644
--- a/microcoap/endpoints.c
+++ b/microcoap/endpoints.c
@@ -6,14 +6,14 @@
 #define ENABLE_DEBUG    (0)
 #include "debug.h"

-uint16_t response_len = 1500;
-static char response[response_len] = "";
+#define RESPONSE_LEN   (1500)
+static char response[RESPONSE_LEN] = "";

 static const coap_endpoint_path_t path = {2, {"foo", "bar"}};

 void create_response(void)
 {
-    strncat(response, "1337", response_len-5);
+    strncat(response, "1337", RESPONSE_LEN-5);
 }

 /* The handler which handles the path /foo/bar */

fixes it.

Lotterleben · 2015-03-04T14:17:47Z

That one seems to haunt me :D This was already fixed, but I must've lost it in the rebase... Sorry. 1sec.

Lotterleben · 2015-03-04T14:20:07Z

Wait.. How did you get that? I can't seem to find the offending line(s) in the current code.

miri64 · 2015-03-04T14:22:58Z

Arghs checked out wrong branch 😊

miri64 · 2015-03-04T14:23:58Z

All is fine: ACK

add microcoap example application

Lotterleben · 2015-03-04T14:25:04Z

✨ Thanks for reviewing! :)

…example add microcoap example application

Lotterleben force-pushed the microcoap_example branch from 5ee902b to 141ea34 Compare February 10, 2015 19:53

Lotterleben assigned miri64 Feb 10, 2015

Lotterleben force-pushed the microcoap_example branch from 245e9c9 to 498aee1 Compare February 16, 2015 00:06

miri64 reviewed Feb 20, 2015
View reviewed changes

microcoap/Makefile Outdated

Copy link
Copy Markdown

Member

miri64 Feb 20, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the out-commented flag

add microcoap example application

7daa0c0

Lotterleben force-pushed the microcoap_example branch from aacb578 to 7daa0c0 Compare March 4, 2015 14:03

miri64 added a commit that referenced this pull request Mar 4, 2015

Merge pull request #2 from Lotterleben/microcoap_example

efb0740

add microcoap example application

miri64 merged commit efb0740 into RIOT-OS:master Mar 4, 2015

chrysn pushed a commit to chrysn-pull-requests/RIOT that referenced this pull request Sep 20, 2022

Merge pull request RIOT-OS/applications#2 from Lotterleben/microcoap_…

db292ba

…example add microcoap example application

Conversation

Lotterleben commented Feb 10, 2015

Uh oh!

jnohlgard commented Feb 14, 2015

Uh oh!

Lotterleben commented Feb 15, 2015

Uh oh!

Lotterleben commented Feb 15, 2015

Uh oh!

miri64 Feb 20, 2015

Choose a reason for hiding this comment

Uh oh!

Lotterleben commented Feb 24, 2015

Uh oh!

Lotterleben commented Feb 24, 2015

Uh oh!

miri64 commented Mar 4, 2015

Uh oh!

Lotterleben commented Mar 4, 2015

Uh oh!

miri64 commented Mar 4, 2015

Uh oh!

miri64 commented Mar 4, 2015

Uh oh!

Lotterleben commented Mar 4, 2015

Uh oh!

Lotterleben commented Mar 4, 2015

Uh oh!

miri64 commented Mar 4, 2015

Uh oh!

miri64 commented Mar 4, 2015

Uh oh!

Lotterleben commented Mar 4, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants